You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/06 19:10:12 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24301: fix: Ability to share saved queries
codecov[bot] commented on PR #24301:
URL: https://github.com/apache/superset/pull/24301#issuecomment-1579308530
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24301](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5bef557) into [master](https://app.codecov.io/gh/apache/superset/commit/ede6acdb3afdf4003359b0c6e2aa8c4b154773ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ede6acd) will **decrease** coverage by `9.27%`.
> The diff coverage is `73.40%`.
> :exclamation: Current head 5bef557 differs from pull request most recent head 36052ed. Consider uploading reports for the commit 36052ed to get more accurate results
```diff
@@ Coverage Diff @@
## master #24301 +/- ##
==========================================
- Coverage 66.53% 57.26% -9.27%
==========================================
Files 1957 1957
Lines 75623 75697 +74
Branches 8224 8223 -1
==========================================
- Hits 50312 43349 -6963
- Misses 23202 30240 +7038
+ Partials 2109 2108 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.44% <73.40%> (?)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.36% <73.40%> (?)` | |
| python | `59.97% <73.40%> (-19.17%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.49% <73.40%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.66% <ø> (ø)` | |
| [...d/src/SqlLab/components/ShareSqlLabQuery/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkvaW5kZXgudHN4) | `84.61% <ø> (+3.13%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/fixtures.ts](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9maXh0dXJlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/types.ts](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi90eXBlcy50cw==) | `57.14% <ø> (ø)` | |
| [...perset-frontend/src/pages/SavedQueryList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL1NhdmVkUXVlcnlMaXN0L2luZGV4LnRzeA==) | `64.60% <ø> (-0.32%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `74.20% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/utils/core.py](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `65.10% <16.66%> (-23.38%)` | :arrow_down: |
| [superset/queries/saved\_queries/dao.py](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2Rhby5weQ==) | `54.28% <38.46%> (-32.08%)` | :arrow_down: |
| [superset/queries/saved\_queries/api.py](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `60.90% <68.75%> (-31.48%)` | :arrow_down: |
| [superset/views/sql\_lab/views.py](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi92aWV3cy5weQ==) | `59.88% <83.33%> (-3.94%)` | :arrow_down: |
| ... and [4 more](https://app.codecov.io/gh/apache/superset/pull/24301?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [352 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24301/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org