[GitHub] [maven-enforcer] timtebeek commented on a change in pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

[GitBox <gi...@apache.org>]

timtebeek commented on a change in pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#discussion_r750608081



##########
File path: pom.xml
##########
@@ -128,22 +128,15 @@
         <scope>test</scope>
       </dependency>
       <dependency>
-        <!-- Needed as PlexusTestCase extends junit.framework.TestCase -->
-        <groupId>junit</groupId>
-        <artifactId>junit</artifactId>
-        <version>4.13.2</version>
-        <scope>test</scope>
-      </dependency>
-      <dependency>
-        <groupId>org.mockito</groupId>
-        <artifactId>mockito-core</artifactId>
-        <version>4.0.0</version>
+        <groupId>org.junit.jupiter</groupId>
+        <artifactId>junit-jupiter-engine</artifactId>

Review comment:
       Without `junit-jupiter-engine` the tests fail in both `enforcer-rules` and `maven-enforcer-plugin`.
   
   I had run `dependency:tree`, which shows JUnit 4 is no longer on the classpath.
   
   `dependency:analyze` shows `enforcer-rules` would only need `mockito-core` as opposed to `mockito-junit-jupiter`, but then you'd have to manage that dependency as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org