You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/05/20 16:27:40 UTC
[GitHub] [eventmesh] mxsm opened a new pull request, #3986: [ISSUE #3985]Fix cannot resolve method getSubystem in PubSubConfig and code style
mxsm opened a new pull request, #3986:
URL: https://github.com/apache/eventmesh/pull/3986
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3985
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
- *Fix cannot resolve method getSubystem in PubSubConfig*
- *Fix code style*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3986: [ISSUE #3985]Fix cannot resolve method getSubystem in PubSubConfig and code style
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3986:
URL: https://github.com/apache/eventmesh/pull/3986#issuecomment-1556156245
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3986?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3986](https://app.codecov.io/gh/apache/eventmesh/pull/3986?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (68d4792) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/39324be50ededf26f4a9ea95ca23355b9e00c91b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (39324be) will **increase** coverage by `0.08%`.
> The diff coverage is `88.88%`.
> :exclamation: Current head 68d4792 differs from pull request most recent head d484ac2. Consider uploading reports for the commit d484ac2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3986 +/- ##
============================================
+ Coverage 13.93% 14.01% +0.08%
- Complexity 1290 1292 +2
============================================
Files 571 572 +1
Lines 28803 28832 +29
Branches 2807 2795 -12
============================================
+ Hits 4013 4041 +28
- Misses 24414 24415 +1
Partials 376 376
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/eventmesh/runtime/boot/EventMeshStartup.java](https://app.codecov.io/gh/apache/eventmesh/pull/3986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoU3RhcnR1cC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/eventmesh/runtime/util/BannerUtil.java](https://app.codecov.io/gh/apache/eventmesh/pull/3986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvQmFubmVyVXRpbC5qYXZh) | `91.42% <91.42%> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3986/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] lrhkobe commented on a diff in pull request #3986: [ISSUE #3985]Fix cannot resolve method getSubystem in PubSubConfig and code style
Posted by "lrhkobe (via GitHub)" <gi...@apache.org>.
lrhkobe commented on code in PR #3986:
URL: https://github.com/apache/eventmesh/pull/3986#discussion_r1199891727
##########
eventmesh-connector-sdks/eventmesh-connector-sdk-java/src/main/java/org/apache/eventmesh/connector/util/ConfigUtil.java:
##########
Review Comment:
What's the change of this file? There is no difference between deleted method and added method. If there are no modifications, do not submit to avoid confusion for the reviewer to understand what has been changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3986: [ISSUE #3985]Fix cannot resolve method getSubystem in PubSubConfig and code style
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3986:
URL: https://github.com/apache/eventmesh/pull/3986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on a diff in pull request #3986: [ISSUE #3985]Fix cannot resolve method getSubystem in PubSubConfig and code style
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #3986:
URL: https://github.com/apache/eventmesh/pull/3986#discussion_r1199745961
##########
eventmesh-connector-sdks/eventmesh-connector-sdk-java/src/main/java/org/apache/eventmesh/connector/api/config/PubSubConfig.java:
##########
@@ -38,4 +38,6 @@ public class PubSubConfig {
private String passWord;
+ private String subsystem;
Review Comment:
here don't use the subsystem, use `appId` instead which is in `PubSubConfig` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mxsm commented on a diff in pull request #3986: [ISSUE #3985]Fix cannot resolve method getSubystem in PubSubConfig and code style
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #3986:
URL: https://github.com/apache/eventmesh/pull/3986#discussion_r1199985210
##########
eventmesh-connector-sdks/eventmesh-connector-sdk-java/src/main/java/org/apache/eventmesh/connector/util/ConfigUtil.java:
##########
Review Comment:
fix code style check not pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mxsm commented on pull request #3986: [ISSUE #3985]Fix cannot resolve method getSubystem in PubSubConfig and code style
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #3986:
URL: https://github.com/apache/eventmesh/pull/3986#issuecomment-1556182184
@xwm1992 PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org