You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/09 05:14:53 UTC
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3344
to review the following change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.
Added a test that disables the failure detector and waits for a single
node to become leader anyway.
Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
2 files changed, 27 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3344/1
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1788/
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#4).
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.
Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/raft_consensus-itest.cc
3 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3344/4
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/1813/
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3344/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
Line 312: bool only_voter = false;
> pull this out to a method. something like IsSingleNodeConfig() or IsSingleV
Done
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 2:
> (1 comment)
>
> can you add a test for this? something simple like setting the
> election timeout really high and then making sure we get a leader
> immediately?
Good idea. I had a test but it I removed it since I didn't want to add an additional gflag just for this.
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 5: Verified+1
Overriding Jenkins, which is currently broken
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3344
to look at the new patch set (#2).
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.
Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3344/2
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3344
to look at the new patch set (#5).
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.
Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/raft_consensus-itest.cc
3 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3344/5
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3344/4/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:
PS4, Line 293: tablet
no need to mention "tablet", i.e. "...Raft configuration."
Line 294: Status IsSingleVoterConfig(bool* only_voter) const;
you use "single" here and "only" in the param, can you refactor the param to be "single" too?
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/1803/
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.
Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Reviewed-on: http://gerrit.cloudera.org:8080/3344
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/raft_consensus-itest.cc
3 files changed, 28 insertions(+), 3 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Mike Percy: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3344/4/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:
PS4, Line 293: tablet
> no need to mention "tablet", i.e. "...Raft configuration."
Done
Line 294: Status IsSingleVoterConfig(bool* only_voter) const;
> you use "single" here and "only" in the param, can you refactor the param t
Done
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 5:
Build Started http://104.196.14.100/job/kudu-gerrit/1840/
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins due to super flaky Java test org.kududb.client.TestAsyncKuduClient.testDisconnect()
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#3).
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.
Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/raft_consensus-itest.cc
3 files changed, 28 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3344/3
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 2:
(1 comment)
can you add a test for this? something simple like setting the election timeout really high and then making sure we get a leader immediately?
http://gerrit.cloudera.org:8080/#/c/3344/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
Line 312: bool only_voter = false;
pull this out to a method. something like IsSingleNodeConfig() or IsSingleVoterConfig
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] RaftConsensus: Trigger election at startup if single node
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
......................................................................
Patch Set 4:
Build Started http://104.196.14.100/job/kudu-gerrit/1816/
--
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No