You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/07/29 11:05:21 UTC

[GitHub] [accumulo] dlmarion commented on a diff in pull request #2834: Provide getProperties method on Configuration that does not filter

dlmarion commented on code in PR #2834:
URL: https://github.com/apache/accumulo/pull/2834#discussion_r933121803


##########
core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java:
##########
@@ -71,17 +70,13 @@ private static class PrefixProps {
   /**
    * Gets a property value from this configuration.
    *
-   * <p>
-   * Note: this is inefficient, but convenient on occasion. For retrieving multiple properties, use
-   * {@link #getProperties(Map, Predicate)} with a custom filter.
-   *

Review Comment:
   > The comment that this is inefficient for multiple properties still applies
   
   Yeah, that's fair. I can put the comment back into the javadoc for that method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org