You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by an...@apache.org on 2008/01/23 06:52:03 UTC
svn commit: r614427 -
/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
Author: andyhot
Date: Tue Jan 22 21:51:47 2008
New Revision: 614427
URL: http://svn.apache.org/viewvc?rev=614427&view=rev
Log:
TAPESTRY-2062: javascriptManager not really used by Shell
Modified:
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc?rev=614427&r1=614426&r2=614427&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc Tue Jan 22 21:51:47 2008
@@ -189,7 +189,6 @@
<inject property="pageService" object="engine-service:page" />
<inject property="applicationSpecification" object="infrastructure:applicationSpecification" />
<inject property="baseTagWriter" object="service:tapestry.url.BaseTagWriter" />
- <inject property="jsManager" object="service:tapestry.js.JavascriptManager" />
<bean name="coreAjaxDelegate" class="org.apache.tapestry.dojo.AjaxShellDelegate">
<set name="dojoSource" value="dojoSource" />
Re: svn commit: r614427 - /tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
Posted by Jesse Kuhnert <jk...@gmail.com>.
Eh....We can probably blame maven for this again since the normal
integration tests weren't runnable previously without having the whole
thing blow up. (the integration tests are currently disabled, but
would have caught this)
I'll see if they can be enabled again. (though I wouldn't keep my hopes up)
On Jan 23, 2008 4:21 PM, Andreas Andreou <an...@gmail.com> wrote:
> yep - i messed up big time... it's needed back.
>
> However, this doesn't really affect the other js libraries
> (and TAPESTRY-2062) after all since they just provide their own
> AjaxDelegate and don't really mess with or need to be configured
> by @Shell directly
>
> thx!
>
>
>
>
> On Jan 23, 2008 10:50 PM, Jesse Kuhnert <jk...@gmail.com> wrote:
> > I think it does actually get used by Shell.
> > (tapestrySource/tapestryPath/dojoSource/dojoPath/etc...)
> >
> > I'm adding it back in for now, maybe there is a better way to do it though?
> >
> >
> > On Jan 23, 2008 12:52 AM, <an...@apache.org> wrote:
> > > Author: andyhot
> > > Date: Tue Jan 22 21:51:47 2008
> > > New Revision: 614427
> > >
> > > URL: http://svn.apache.org/viewvc?rev=614427&view=rev
> > > Log:
> > > TAPESTRY-2062: javascriptManager not really used by Shell
> > >
> > > Modified:
> > > tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
> > >
> > > Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
> > > URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc?rev=614427&r1=614426&r2=614427&view=diff
> > > ==============================================================================
> > > --- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc (original)
> > > +++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc Tue Jan 22 21:51:47 2008
> > > @@ -189,7 +189,6 @@
> > > <inject property="pageService" object="engine-service:page" />
> > > <inject property="applicationSpecification" object="infrastructure:applicationSpecification" />
> > > <inject property="baseTagWriter" object="service:tapestry.url.BaseTagWriter" />
> > > - <inject property="jsManager" object="service:tapestry.js.JavascriptManager" />
> > >
> > > <bean name="coreAjaxDelegate" class="org.apache.tapestry.dojo.AjaxShellDelegate">
> > > <set name="dojoSource" value="dojoSource" />
> > >
> > >
> > >
> >
> >
> >
> > --
> > Jesse Kuhnert
> > Tapestry / OGNL / Dojo team member/developer
> >
> > Open source based consulting work centered around
> > dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> > For additional commands, e-mail: dev-help@tapestry.apache.org
> >
> >
>
>
>
> --
> Andreas Andreou - andyhot@apache.org - http://blog.andyhot.gr
> Tapestry / Tacos developer
> Open Source / JEE Consulting
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
--
Jesse Kuhnert
Tapestry / OGNL / Dojo team member/developer
Open source based consulting work centered around
dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: svn commit: r614427 - /tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
Posted by Andreas Andreou <an...@gmail.com>.
yep - i messed up big time... it's needed back.
However, this doesn't really affect the other js libraries
(and TAPESTRY-2062) after all since they just provide their own
AjaxDelegate and don't really mess with or need to be configured
by @Shell directly
thx!
On Jan 23, 2008 10:50 PM, Jesse Kuhnert <jk...@gmail.com> wrote:
> I think it does actually get used by Shell.
> (tapestrySource/tapestryPath/dojoSource/dojoPath/etc...)
>
> I'm adding it back in for now, maybe there is a better way to do it though?
>
>
> On Jan 23, 2008 12:52 AM, <an...@apache.org> wrote:
> > Author: andyhot
> > Date: Tue Jan 22 21:51:47 2008
> > New Revision: 614427
> >
> > URL: http://svn.apache.org/viewvc?rev=614427&view=rev
> > Log:
> > TAPESTRY-2062: javascriptManager not really used by Shell
> >
> > Modified:
> > tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
> >
> > Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
> > URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc?rev=614427&r1=614426&r2=614427&view=diff
> > ==============================================================================
> > --- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc (original)
> > +++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc Tue Jan 22 21:51:47 2008
> > @@ -189,7 +189,6 @@
> > <inject property="pageService" object="engine-service:page" />
> > <inject property="applicationSpecification" object="infrastructure:applicationSpecification" />
> > <inject property="baseTagWriter" object="service:tapestry.url.BaseTagWriter" />
> > - <inject property="jsManager" object="service:tapestry.js.JavascriptManager" />
> >
> > <bean name="coreAjaxDelegate" class="org.apache.tapestry.dojo.AjaxShellDelegate">
> > <set name="dojoSource" value="dojoSource" />
> >
> >
> >
>
>
>
> --
> Jesse Kuhnert
> Tapestry / OGNL / Dojo team member/developer
>
> Open source based consulting work centered around
> dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
--
Andreas Andreou - andyhot@apache.org - http://blog.andyhot.gr
Tapestry / Tacos developer
Open Source / JEE Consulting
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: svn commit: r614427 - /tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
Posted by Jesse Kuhnert <jk...@gmail.com>.
I think it does actually get used by Shell.
(tapestrySource/tapestryPath/dojoSource/dojoPath/etc...)
I'm adding it back in for now, maybe there is a better way to do it though?
On Jan 23, 2008 12:52 AM, <an...@apache.org> wrote:
> Author: andyhot
> Date: Tue Jan 22 21:51:47 2008
> New Revision: 614427
>
> URL: http://svn.apache.org/viewvc?rev=614427&view=rev
> Log:
> TAPESTRY-2062: javascriptManager not really used by Shell
>
> Modified:
> tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
>
> Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc
> URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc?rev=614427&r1=614426&r2=614427&view=diff
> ==============================================================================
> --- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc (original)
> +++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Shell.jwc Tue Jan 22 21:51:47 2008
> @@ -189,7 +189,6 @@
> <inject property="pageService" object="engine-service:page" />
> <inject property="applicationSpecification" object="infrastructure:applicationSpecification" />
> <inject property="baseTagWriter" object="service:tapestry.url.BaseTagWriter" />
> - <inject property="jsManager" object="service:tapestry.js.JavascriptManager" />
>
> <bean name="coreAjaxDelegate" class="org.apache.tapestry.dojo.AjaxShellDelegate">
> <set name="dojoSource" value="dojoSource" />
>
>
>
--
Jesse Kuhnert
Tapestry / OGNL / Dojo team member/developer
Open source based consulting work centered around
dojo/tapestry/tacos/hivemind. http://blog.opencomponentry.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org