You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/20 12:46:51 UTC

[GitHub] [pulsar] bbl opened a new pull request #7322: Fixing go instance config port apache/pulsar#7267

bbl opened a new pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322


   
   
   Fixes #7267 
   
   
   ### Motivation
   
   As described in the original issue, whenever you're trying to `localrun` or `create` a golang function - the process port is set to 0. This leads to health checks errors.
   
   ### Modifications
   
   The original method that returns golang cmd arguments didn't use the `port` variable 
   from the instanceConfig parameter.  
   This is a one-line modification that fixes the problem.
   
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   - [x] This change is a trivial rework without any test coverage.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (yes, it fixes the creation/localrun of golang functions)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-652781065


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653833468


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653435147


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653311428


   @bbl can you merge the master code?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] bbl commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
bbl commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653363016


   @wolfstudy sure! Done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653304114


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653838722


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy merged pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653296459


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7322: [Issue 7267] Fixing go instance config port

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7322:
URL: https://github.com/apache/pulsar/pull/7322#issuecomment-653306125


   ```
   Run sudo swapoff /swapfile
   swapoff: /swapfile: swapoff failed: No such file or directory
   ##[error]Process completed with exit code 255.
   ```
   
   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org