[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #4124: Fix incorrect error handling on validate server capabilities

[GitBox <gi...@apache.org>]

ocket8888 edited a comment on issue #4124: Fix incorrect error handling on validate server capabilities
URL: https://github.com/apache/trafficcontrol/pull/4124#issuecomment-555578297
 
 
   So I created a capability 'foo' and assigned it to a Delivery Service, then created a new Edge-tier server (id 14) and tried to assign it to the Delivery Service (while it didn't have the required capability). What I got was strange:
   ```http
   POST /api/1.4/deliveryservices/demo1/servers HTTP/1.1
   User-Agent: python-requests/2.22.0
   Accept-Encoding: gzip, deflate
   Accept: */*
   Connection: keep-alive
   Content-Length: 19
   
   {"serverIds": [14]}
   ```
   
   ```http
   HTTP/1.1 200 OK
   Content-Encoding: gzip
   Content-Type: application/json
   X-Server-Name: traffic_ops_golang/
   Date: Tue, 19 Nov 2019 16:04:33 GMT
   Content-Length: 74
   
   {
   	"response": {
   		"serverNames": null,
   		"xmlId": "demo1"
   	}
   }
   ```
   The changes you made look proper, so I'm confused why I'm seeing a 200 response?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services