Re: [PR] ZOOKEEPER-5106: DnsSrvHostProvider ignores the refresh interval set in ZKClientConfig [zookeeper]

["kezhuw (via GitHub)" <gi...@apache.org>]

kezhuw commented on code in PR #2479:
URL: https://github.com/apache/zookeeper/pull/2479#discussion_r4344429381


##########
zookeeper-server/src/main/java/org/apache/zookeeper/client/DnsSrvHostProvider.java:
##########
@@ -199,9 +199,10 @@ public void close() {
         }
     }
 
-    private long getRefreshInterval() {
+    private long getRefreshInterval(final ZKClientConfig clientConfig) {
+        final ZKClientConfig config = clientConfig == null ? new ZKClientConfig() : clientConfig;

Review Comment:
   Shall we construct a `ZKClientConfig` if none provided and pass it to `HostConnectionManager` ? So the two see a consistent view of client config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org