[GitHub] [jena] afs commented on a change in pull request #806: JENA-1975: Clean up logging

[GitBox <gi...@apache.org>]

afs commented on a change in pull request #806:
URL: https://github.com/apache/jena/pull/806#discussion_r498474343



##########
File path: jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/JettyServer.java
##########
@@ -352,7 +387,17 @@ protected void addFilter(ServletContextHandler context, String pathspec, Filter
         }
 
         /** Jetty server */
-        private static Server jettyServer(int port, boolean loopback) {
+        private static Server jettyServer(int port, boolean loopback, int minThreads, int maxThreads) {
+            ThreadPool threadPool = null;
+            // Jetty 9.4 : the Jetty default is200,8

Review comment:
       It really is 200,8 -- Jetty arguments are (max,min).
   
   [QueuedThreadPool.java in Jetty 9.4](https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java)
   
   One of the reasons for messing with this is that it becomes hard to debug with even the minimum 8 threads when you pause the whole JVM and want to find a thread in a particular state, especially if (for Delta testing) there are multiple Jetty servers in one JVM.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org