[jira] Commented: (TAP5-1206) @IncludeStylesheet slows down component rendering

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887834#action_12887834 ] 

Howard M. Lewis Ship commented on TAP5-1206:
--------------------------------------------

That's interesting. It must be a difference in how the Assets are resolved and cached, since the generated logic is virtually identical to what you have there.  All of this stuff has been reworked in Tapestry 5.2 and we're just getting to the profiling stage.

> @IncludeStylesheet slows down component rendering
> -------------------------------------------------
>
>                 Key: TAP5-1206
>                 URL: https://issues.apache.org/jira/browse/TAP5-1206
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Michael Wyraz
>
> We have a component (Button with it's own css) that is rendered multiple times into a table (in some cases >3000 times). The css is included via @IncludeStylesheet. Rendering 3000 of this buttons requires about 6-7 seconds on server side. When I change the button code to:
> 	@Inject
> 	private RenderSupport renderSupport;
> 	
> 	@Inject
> 	@Path("ActionButton.css")
> 	private Asset stylesheet;
> 	
> 	@SetupRender
> 	public void setup()
> 	{
> 		renderSupport.addStylesheetLink(stylesheet, null);
> 	}
> (instead of @IncludeStylesheet) rendering happens in less than 1 second. So I guess that the inserted code is very inefficient and should be replaced by something like the code above.
> (whish) If you touch the code, please add a media attribute to the annotation ;-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.