You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/05/20 02:27:31 UTC
Review Request 34449: Validating INSTANCES_SPEC_ARGUMENT option range
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34449/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1296
https://issues.apache.org/jira/browse/AURORA-1296
Repository: aurora
Description
-------
Aborting on invalid instances option range.
Diffs
-----
src/main/python/apache/aurora/client/cli/options.py 07344b318a51636823ab67ec3441e7465a34d7b1
src/test/python/apache/aurora/client/cli/BUILD 26d11a36a16fc67a7a79b175fc550b12c1866bbe
src/test/python/apache/aurora/client/cli/test_options.py PRE-CREATION
Diff: https://reviews.apache.org/r/34449/diff/
Testing
-------
./pants test.pytest src/test/python:all
vagrant@192:~$ aurora job kill --no-batching devcluster/www-data/prod/hello/1-0
usage: aurora job kill [-h] [--open-browser] [--bind var=value] [--read-json]
[--config pathname] [--batch-size BATCH_SIZE]
[--max-total-failures MAX_TOTAL_FAILURES]
[--no-batching] [--strict] [--verbose]
[--skip-hooks hook,hook,...]
CLUSTER/ROLE/ENV/NAME[/INSTANCES]
aurora job kill: error: argument CLUSTER/ROLE/ENV/NAME[/INSTANCES]: Invalid instance range: ['1', '0']
Thanks,
Maxim Khutornenko
Re: Review Request 34449: Validating INSTANCES_SPEC_ARGUMENT option
range
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34449/#review84430
-----------------------------------------------------------
Ship it!
Master (920263b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 20, 2015, 12:27 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34449/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 12:27 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1296
> https://issues.apache.org/jira/browse/AURORA-1296
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Aborting on invalid instances option range.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 07344b318a51636823ab67ec3441e7465a34d7b1
> src/test/python/apache/aurora/client/cli/BUILD 26d11a36a16fc67a7a79b175fc550b12c1866bbe
> src/test/python/apache/aurora/client/cli/test_options.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34449/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest src/test/python:all
>
> vagrant@192:~$ aurora job kill --no-batching devcluster/www-data/prod/hello/1-0
> usage: aurora job kill [-h] [--open-browser] [--bind var=value] [--read-json]
> [--config pathname] [--batch-size BATCH_SIZE]
> [--max-total-failures MAX_TOTAL_FAILURES]
> [--no-batching] [--strict] [--verbose]
> [--skip-hooks hook,hook,...]
> CLUSTER/ROLE/ENV/NAME[/INSTANCES]
> aurora job kill: error: argument CLUSTER/ROLE/ENV/NAME[/INSTANCES]: Invalid instance range: ['1', '0']
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 34449: Validating INSTANCES_SPEC_ARGUMENT option
range
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34449/#review84428
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On May 19, 2015, 5:27 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34449/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 5:27 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1296
> https://issues.apache.org/jira/browse/AURORA-1296
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Aborting on invalid instances option range.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 07344b318a51636823ab67ec3441e7465a34d7b1
> src/test/python/apache/aurora/client/cli/BUILD 26d11a36a16fc67a7a79b175fc550b12c1866bbe
> src/test/python/apache/aurora/client/cli/test_options.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34449/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest src/test/python:all
>
> vagrant@192:~$ aurora job kill --no-batching devcluster/www-data/prod/hello/1-0
> usage: aurora job kill [-h] [--open-browser] [--bind var=value] [--read-json]
> [--config pathname] [--batch-size BATCH_SIZE]
> [--max-total-failures MAX_TOTAL_FAILURES]
> [--no-batching] [--strict] [--verbose]
> [--skip-hooks hook,hook,...]
> CLUSTER/ROLE/ENV/NAME[/INSTANCES]
> aurora job kill: error: argument CLUSTER/ROLE/ENV/NAME[/INSTANCES]: Invalid instance range: ['1', '0']
>
>
> Thanks,
>
> Maxim Khutornenko
>
>