You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2018/01/31 07:58:19 UTC

Review Request 65430: Virtual fact start and end time property fix

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65430/
-----------------------------------------------------------

Review request for lens and Puneet Gupta.


Bugs: LENS-1480
    https://issues.apache.org/jira/browse/LENS-1480


Repository: lens


Description
-------

Virtual fact start and end time property fix


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java b48be7f 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java fe6b20d 
  lens-cube/src/test/resources/schema/cubes/base/testcube2.xml 237e85a 
  lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 187ac29 
  lens-cube/src/test/resources/schema/facts/testfact9_base.xml 9c94fe2 
  lens-cube/src/test/resources/schema/facts/virtual/virtualfact2.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/65430/diff/1/


Testing
-------


Thanks,

Rajitha R

Re: Review Request 65430: Virtual fact start and end time property fix

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65430/#review199519
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Jan. 31, 2018, 7:58 a.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65430/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 7:58 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1502
>     https://issues.apache.org/jira/browse/LENS-1502
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Virtual fact start and end time property fix
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java b48be7f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java fe6b20d 
>   lens-cube/src/test/resources/schema/cubes/base/testcube2.xml 237e85a 
>   lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 187ac29 
>   lens-cube/src/test/resources/schema/facts/testfact9_base.xml 9c94fe2 
>   lens-cube/src/test/resources/schema/facts/virtual/virtualfact2.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65430/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>