[GitHub] [druid] suneet-s commented on a change in pull request #9287: Add getRightColumns to JoinConditionAnalysis

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9287: Add getRightColumns to JoinConditionAnalysis
URL: https://github.com/apache/druid/pull/9287#discussion_r372627563
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/segment/join/JoinConditionAnalysisTest.java
 ##########
 @@ -60,6 +61,7 @@ public void test_forExpression_simple()
         ImmutableList.of(),
         exprsToStrings(analysis.getNonEquiConditions())
     );
+    Assert.assertThat(analysis.getRightKeyColumns(), CoreMatchers.is(ImmutableList.of("y")));
 
 Review comment:
   assertEquals fails because getRightKeyColumns doesn't return an ImmutableList

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org