[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2386: [Engine][Task] Add task runtime logic

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #2386:
URL: https://github.com/apache/incubator-seatunnel/pull/2386#discussion_r942017385


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/Record.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.api.table.type;
+
+/**
+ * Contain {@link SeaTunnelRow} or Checkpoint Barrier
+ */
+public class Record {

Review Comment:
   Does `Record` need implements `IdentifiedDataSerializable`?



##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/IntermediateQueueFlowLifeCycle.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.engine.server.task.flow;
+
+import org.apache.seatunnel.api.transform.Collector;
+
+import java.util.concurrent.BlockingQueue;
+
+public class IntermediateQueueFlowLifeCycle<T> implements OneInputFlowLifeCycle<T>, OneOutputFlowLifeCycle<T> {
+
+    private final BlockingQueue<T> queue;
+
+    public IntermediateQueueFlowLifeCycle(BlockingQueue<T> queue) {
+        this.queue = queue;
+    }
+
+    @Override
+    public void received(T row) {
+        try {
+            queue.put(row);

Review Comment:
   Will we consider supporting batch put



##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/IntermediateQueueFlowLifeCycle.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.engine.server.task.flow;
+
+import org.apache.seatunnel.api.transform.Collector;
+
+import java.util.concurrent.BlockingQueue;
+
+public class IntermediateQueueFlowLifeCycle<T> implements OneInputFlowLifeCycle<T>, OneOutputFlowLifeCycle<T> {
+
+    private final BlockingQueue<T> queue;
+
+    public IntermediateQueueFlowLifeCycle(BlockingQueue<T> queue) {
+        this.queue = queue;
+    }
+
+    @Override
+    public void received(T row) {
+        try {
+            queue.put(row);
+        } catch (InterruptedException e) {
+            throw new RuntimeException(e);
+        }
+    }
+
+    @Override
+    public void collect(Collector<T> collector) throws Exception {
+        while (true) {
+            T record = queue.poll();
+            if (record != null) {
+                collector.collect(record);
+            } else {
+                break;

Review Comment:
   This function will never return if there is always data in the queue. Is this what we expect?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org