You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gluten.apache.org by WeitingChen <we...@apache.org> on 2024/03/27 14:07:32 UTC

About Branch Protection rule

Currently, Gluten's Branch Protection rule is null, which means no rule
right now and anyone who has written permission can merge PR.
Many developers from multiple companies highlight this and request to set a
more strict rule.
Before we contribute to Apache the rule is set to *require at least one
review approval* before merging PRs.
Please let me know if there are any comments or just approve this.

Thanks,
William Chen

RE: About Branch Protection rule

Posted by "Yang, Binwei" <bi...@intel.com>.
+1



Thanks
Binwei

-----Original Message-----
From: XiDuo You <ul...@gmail.com> 
Sent: Thursday, March 28, 2024 5:33 AM
To: dev@gluten.apache.org
Subject: Re: About Branch Protection rule

Thank you Weiting!

+1

Jacky Lee <qc...@gmail.com> 于2024年3月28日周四 16:01写道:
>
> +1
>
> Yang Zhang <ya...@apache.org> 于2024年3月28日周四 15:50写道:
> >
> > +1
> >
> > On 2024/03/27 14:07:32 WeitingChen wrote:
> > > Currently, Gluten's Branch Protection rule is null, which means no 
> > > rule right now and anyone who has written permission can merge PR.
> > > Many developers from multiple companies highlight this and request 
> > > to set a more strict rule.
> > > Before we contribute to Apache the rule is set to *require at 
> > > least one review approval* before merging PRs.
> > > Please let me know if there are any comments or just approve this.
> > >
> > > Thanks,
> > > William Chen
> > >
> >
> > --------------------------------------------------------------------
> > - To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org For 
> > additional commands, e-mail: dev-help@gluten.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org For 
> additional commands, e-mail: dev-help@gluten.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org For additional commands, e-mail: dev-help@gluten.apache.org


Re: About Branch Protection rule

Posted by XiDuo You <ul...@gmail.com>.
Thank you Weiting!

+1

Jacky Lee <qc...@gmail.com> 于2024年3月28日周四 16:01写道:
>
> +1
>
> Yang Zhang <ya...@apache.org> 于2024年3月28日周四 15:50写道:
> >
> > +1
> >
> > On 2024/03/27 14:07:32 WeitingChen wrote:
> > > Currently, Gluten's Branch Protection rule is null, which means no rule
> > > right now and anyone who has written permission can merge PR.
> > > Many developers from multiple companies highlight this and request to set a
> > > more strict rule.
> > > Before we contribute to Apache the rule is set to *require at least one
> > > review approval* before merging PRs.
> > > Please let me know if there are any comments or just approve this.
> > >
> > > Thanks,
> > > William Chen
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org
> > For additional commands, e-mail: dev-help@gluten.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org
> For additional commands, e-mail: dev-help@gluten.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org
For additional commands, e-mail: dev-help@gluten.apache.org


Re: About Branch Protection rule

Posted by Jacky Lee <qc...@gmail.com>.
+1

Yang Zhang <ya...@apache.org> 于2024年3月28日周四 15:50写道:
>
> +1
>
> On 2024/03/27 14:07:32 WeitingChen wrote:
> > Currently, Gluten's Branch Protection rule is null, which means no rule
> > right now and anyone who has written permission can merge PR.
> > Many developers from multiple companies highlight this and request to set a
> > more strict rule.
> > Before we contribute to Apache the rule is set to *require at least one
> > review approval* before merging PRs.
> > Please let me know if there are any comments or just approve this.
> >
> > Thanks,
> > William Chen
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org
> For additional commands, e-mail: dev-help@gluten.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org
For additional commands, e-mail: dev-help@gluten.apache.org


Re: About Branch Protection rule

Posted by Yang Zhang <ya...@apache.org>.
+1

On 2024/03/27 14:07:32 WeitingChen wrote:
> Currently, Gluten's Branch Protection rule is null, which means no rule
> right now and anyone who has written permission can merge PR.
> Many developers from multiple companies highlight this and request to set a
> more strict rule.
> Before we contribute to Apache the rule is set to *require at least one
> review approval* before merging PRs.
> Please let me know if there are any comments or just approve this.
> 
> Thanks,
> William Chen
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org
For additional commands, e-mail: dev-help@gluten.apache.org


Re: About Branch Protection rule

Posted by Kent Yao <ya...@apache.org>.
+1

On 2024/03/28 01:51:28 Zhang Hongze wrote:
> Thanks Weiting.
> 
> > is set to *require at least one review approval*
> 
> If I understand correctly, we are going to add this restriction back to
> Apache Gluten repo, is that correct?
> 
> I think for some trivial PRs committers may want to keep some
> flexibility to merge by themselves as long as they are confident with the
> change. But I don't know an easy way to distinguish between trivial
> and non-trival. So I am +1 to adding the restriction back until we find a
> better way to make some trade-off.
> 
> Thanks,
> Hongze
> 
> On Wed, Mar 27, 2024 at 10:07 PM WeitingChen <we...@apache.org> wrote:
> 
> > Currently, Gluten's Branch Protection rule is null, which means no rule
> > right now and anyone who has written permission can merge PR.
> > Many developers from multiple companies highlight this and request to set a
> > more strict rule.
> > Before we contribute to Apache the rule is set to *require at least one
> > review approval* before merging PRs.
> > Please let me know if there are any comments or just approve this.
> >
> > Thanks,
> > William Chen
> >
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@gluten.apache.org
For additional commands, e-mail: dev-help@gluten.apache.org


Re: About Branch Protection rule

Posted by Zhang Hongze <ho...@apache.org>.
Thanks Weiting.

> is set to *require at least one review approval*

If I understand correctly, we are going to add this restriction back to
Apache Gluten repo, is that correct?

I think for some trivial PRs committers may want to keep some
flexibility to merge by themselves as long as they are confident with the
change. But I don't know an easy way to distinguish between trivial
and non-trival. So I am +1 to adding the restriction back until we find a
better way to make some trade-off.

Thanks,
Hongze

On Wed, Mar 27, 2024 at 10:07 PM WeitingChen <we...@apache.org> wrote:

> Currently, Gluten's Branch Protection rule is null, which means no rule
> right now and anyone who has written permission can merge PR.
> Many developers from multiple companies highlight this and request to set a
> more strict rule.
> Before we contribute to Apache the rule is set to *require at least one
> review approval* before merging PRs.
> Please let me know if there are any comments or just approve this.
>
> Thanks,
> William Chen
>