You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/10 02:34:57 UTC

[GitHub] [shardingsphere] hoorf opened a new pull request, #17504: Add unit test SingleTableSQLRouter#decorateRouteContext

hoorf opened a new pull request, #17504:
URL: https://github.com/apache/shardingsphere/pull/17504

   Fixes #17448 .
   
   Changes proposed in this pull request:
   - add unit test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #17504: Add unit test SingleTableSQLRouter#decorateRouteContext

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #17504:
URL: https://github.com/apache/shardingsphere/pull/17504#discussion_r871999753


##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -104,6 +104,24 @@ public void assertCreateRouteContextWithMultiDataSource() {
         assertFalse(actual.isFederated());
     }
     
+    @Test
+    public void assertDecorateRouteContext() {
+        SingleTableRule singleTableRule = new SingleTableRule(new SingleTableRuleConfiguration(), DefaultDatabase.LOGIC_NAME, mock(DatabaseType.class),
+                createSingleDataSourceMap(), Collections.emptyList(), new ConfigurationProperties(new Properties()));
+        singleTableRule.getSingleTableDataNodes().put("t_order", Collections.singletonList(mockDataNode("ds_0")));
+        ShardingSphereMetaData metaData = mockSingleDataSourceMetaData();
+        RouteContext actual = new RouteContext();

Review Comment:
   Hi @hoorf, please check the `decorateRouteContext` pre-logic, the `decorateRouteContext` method will be executed only when the RouteContext contains `rountUnits`. Also, since there are multiple implementations of SQLRouter, consider testing in multiple combined scenarios.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #17504: Add unit test SingleTableSQLRouter#decorateRouteContext

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #17504:
URL: https://github.com/apache/shardingsphere/pull/17504#discussion_r869372779


##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -146,19 +165,19 @@ private LogicSQL createLogicSQL() {
         SQLStatementContext<CreateTableStatement> sqlStatementContext = new CreateTableStatementContext(createTableStatement);
         return new LogicSQL(sqlStatementContext, "create table", parameters);
     }
-    
+
     private Map<String, DataSource> createSingleDataSourceMap() {
         Map<String, DataSource> result = new HashMap<>(2, 1);
         result.put("ds_0", mock(DataSource.class, RETURNS_DEEP_STUBS));
         return result;
     }
-    
+
     private Map<String, DataSource> createReadwriteSplittingDataSourceMap() {
         Map<String, DataSource> result = new HashMap<>(2, 1);
         result.put("readwrite_ds", mock(DataSource.class, RETURNS_DEEP_STUBS));
         return result;
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -146,19 +165,19 @@ private LogicSQL createLogicSQL() {
         SQLStatementContext<CreateTableStatement> sqlStatementContext = new CreateTableStatementContext(createTableStatement);
         return new LogicSQL(sqlStatementContext, "create table", parameters);
     }
-    
+
     private Map<String, DataSource> createSingleDataSourceMap() {
         Map<String, DataSource> result = new HashMap<>(2, 1);
         result.put("ds_0", mock(DataSource.class, RETURNS_DEEP_STUBS));
         return result;
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -103,29 +103,48 @@ public void assertCreateRouteContextWithMultiDataSource() {
         assertThat(tableMapper.getLogicName(), is("t_order"));
         assertFalse(actual.isFederated());
     }
-    
+
+    @Test
+    public void assertDecorateRouteContext() {
+        SingleTableRule singleTableRule = new SingleTableRule(new SingleTableRuleConfiguration(), DefaultDatabase.LOGIC_NAME, mock(DatabaseType.class),
+                createSingleDataSourceMap(), Collections.emptyList(), new ConfigurationProperties(new Properties()));
+        singleTableRule.getSingleTableDataNodes().put("t_order", Collections.singletonList(mockDataNode("ds_0")));
+        ShardingSphereMetaData metaData = mockSingleDataSourceMetaData();
+        RouteContext actual = new RouteContext();
+        new SingleTableSQLRouter().decorateRouteContext(actual, createLogicSQL(), metaData, singleTableRule, new ConfigurationProperties(new Properties()));
+        List<RouteUnit> routeUnits = new ArrayList<>(actual.getRouteUnits());
+        assertThat(actual.getRouteUnits().size(), is(1));
+        assertThat(routeUnits.get(0).getDataSourceMapper().getLogicName(), is("ds_0"));
+        assertThat(routeUnits.get(0).getDataSourceMapper().getActualName(), is("ds_0"));
+        RouteMapper tableMapper = routeUnits.get(0).getTableMappers().iterator().next();
+        assertThat(tableMapper.getActualName(), is("t_order"));
+        assertThat(tableMapper.getLogicName(), is("t_order"));
+        assertFalse(actual.isFederated());
+    }
+
     private DataNode mockDataNode(final String dataSourceName) {
         DataNode result = new DataNode(dataSourceName, "t_order");
         result.setSchemaName(DefaultDatabase.LOGIC_NAME);
         return result;
     }
-    
+
     private ShardingSphereMetaData mockSingleDataSourceMetaData() {
         ShardingSphereMetaData result = mock(ShardingSphereMetaData.class, RETURNS_DEEP_STUBS);
         Map<String, DataSource> dataSourceMap = new HashMap<>(2, 1);
         dataSourceMap.put("ds_0", mock(DataSource.class, RETURNS_DEEP_STUBS));
         when(result.getResource().getDataSources()).thenReturn(dataSourceMap);
+        when(result.getDatabaseName()).thenReturn(DefaultDatabase.LOGIC_NAME);
         return result;
     }
-    
+
     private ShardingSphereMetaData mockReadwriteSplittingDataSourceMetaData() {
         ShardingSphereMetaData result = mock(ShardingSphereMetaData.class, RETURNS_DEEP_STUBS);
         Map<String, DataSource> dataSourceMap = new HashMap<>(2, 1);
         dataSourceMap.put("write_ds", mock(DataSource.class, RETURNS_DEEP_STUBS));
         when(result.getResource().getDataSources()).thenReturn(dataSourceMap);
         return result;
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -103,29 +103,48 @@ public void assertCreateRouteContextWithMultiDataSource() {
         assertThat(tableMapper.getLogicName(), is("t_order"));
         assertFalse(actual.isFederated());
     }
-    
+
+    @Test
+    public void assertDecorateRouteContext() {
+        SingleTableRule singleTableRule = new SingleTableRule(new SingleTableRuleConfiguration(), DefaultDatabase.LOGIC_NAME, mock(DatabaseType.class),
+                createSingleDataSourceMap(), Collections.emptyList(), new ConfigurationProperties(new Properties()));
+        singleTableRule.getSingleTableDataNodes().put("t_order", Collections.singletonList(mockDataNode("ds_0")));
+        ShardingSphereMetaData metaData = mockSingleDataSourceMetaData();
+        RouteContext actual = new RouteContext();
+        new SingleTableSQLRouter().decorateRouteContext(actual, createLogicSQL(), metaData, singleTableRule, new ConfigurationProperties(new Properties()));
+        List<RouteUnit> routeUnits = new ArrayList<>(actual.getRouteUnits());
+        assertThat(actual.getRouteUnits().size(), is(1));
+        assertThat(routeUnits.get(0).getDataSourceMapper().getLogicName(), is("ds_0"));
+        assertThat(routeUnits.get(0).getDataSourceMapper().getActualName(), is("ds_0"));
+        RouteMapper tableMapper = routeUnits.get(0).getTableMappers().iterator().next();
+        assertThat(tableMapper.getActualName(), is("t_order"));
+        assertThat(tableMapper.getLogicName(), is("t_order"));
+        assertFalse(actual.isFederated());
+    }
+
     private DataNode mockDataNode(final String dataSourceName) {
         DataNode result = new DataNode(dataSourceName, "t_order");
         result.setSchemaName(DefaultDatabase.LOGIC_NAME);
         return result;
     }
-    
+
     private ShardingSphereMetaData mockSingleDataSourceMetaData() {
         ShardingSphereMetaData result = mock(ShardingSphereMetaData.class, RETURNS_DEEP_STUBS);
         Map<String, DataSource> dataSourceMap = new HashMap<>(2, 1);
         dataSourceMap.put("ds_0", mock(DataSource.class, RETURNS_DEEP_STUBS));
         when(result.getResource().getDataSources()).thenReturn(dataSourceMap);
+        when(result.getDatabaseName()).thenReturn(DefaultDatabase.LOGIC_NAME);
         return result;
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -146,19 +165,19 @@ private LogicSQL createLogicSQL() {
         SQLStatementContext<CreateTableStatement> sqlStatementContext = new CreateTableStatementContext(createTableStatement);
         return new LogicSQL(sqlStatementContext, "create table", parameters);
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -135,7 +154,7 @@ private ShardingSphereMetaData mockMultiDataSourceMetaData() {
         when(result.getDatabaseName()).thenReturn(DefaultDatabase.LOGIC_NAME);
         return result;
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -103,29 +103,48 @@ public void assertCreateRouteContextWithMultiDataSource() {
         assertThat(tableMapper.getLogicName(), is("t_order"));
         assertFalse(actual.isFederated());
     }
-    
+
+    @Test
+    public void assertDecorateRouteContext() {
+        SingleTableRule singleTableRule = new SingleTableRule(new SingleTableRuleConfiguration(), DefaultDatabase.LOGIC_NAME, mock(DatabaseType.class),
+                createSingleDataSourceMap(), Collections.emptyList(), new ConfigurationProperties(new Properties()));
+        singleTableRule.getSingleTableDataNodes().put("t_order", Collections.singletonList(mockDataNode("ds_0")));
+        ShardingSphereMetaData metaData = mockSingleDataSourceMetaData();
+        RouteContext actual = new RouteContext();
+        new SingleTableSQLRouter().decorateRouteContext(actual, createLogicSQL(), metaData, singleTableRule, new ConfigurationProperties(new Properties()));
+        List<RouteUnit> routeUnits = new ArrayList<>(actual.getRouteUnits());
+        assertThat(actual.getRouteUnits().size(), is(1));
+        assertThat(routeUnits.get(0).getDataSourceMapper().getLogicName(), is("ds_0"));
+        assertThat(routeUnits.get(0).getDataSourceMapper().getActualName(), is("ds_0"));
+        RouteMapper tableMapper = routeUnits.get(0).getTableMappers().iterator().next();
+        assertThat(tableMapper.getActualName(), is("t_order"));
+        assertThat(tableMapper.getLogicName(), is("t_order"));
+        assertFalse(actual.isFederated());
+    }
+
     private DataNode mockDataNode(final String dataSourceName) {
         DataNode result = new DataNode(dataSourceName, "t_order");
         result.setSchemaName(DefaultDatabase.LOGIC_NAME);
         return result;
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -55,7 +55,7 @@
 import static org.mockito.Mockito.when;
 
 public final class SingleTableSQLRouterTest {
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -85,7 +85,7 @@ public void assertCreateRouteContextWithReadwriteSplittingDataSource() {
         assertTrue(routeUnits.get(0).getTableMappers().isEmpty());
         assertFalse(actual.isFederated());
     }
-    
+

Review Comment:
   Please keep the origin indent



##########
shardingsphere-kernel/shardingsphere-single-table/shardingsphere-single-table-core/src/test/java/org/apache/shardingsphere/singletable/route/SingleTableSQLRouterTest.java:
##########
@@ -70,7 +70,7 @@ public void assertCreateRouteContextWithSingleDataSource() {
         assertTrue(routeUnits.get(0).getTableMappers().isEmpty());
         assertFalse(actual.isFederated());
     }
-    
+

Review Comment:
   Please keep the origin indent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] hoorf closed pull request #17504: Add unit test SingleTableSQLRouter#decorateRouteContext

Posted by GitBox <gi...@apache.org>.
hoorf closed pull request #17504: Add unit test SingleTableSQLRouter#decorateRouteContext
URL: https://github.com/apache/shardingsphere/pull/17504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #17504: Add unit test SingleTableSQLRouter#decorateRouteContext

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #17504:
URL: https://github.com/apache/shardingsphere/pull/17504#issuecomment-1143386784

   Test cases are not in release scope. I'm removing milestone for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17504: Add unit test SingleTableSQLRouter#decorateRouteContext

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17504:
URL: https://github.com/apache/shardingsphere/pull/17504#issuecomment-1124285285

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17504?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17504](https://codecov.io/gh/apache/shardingsphere/pull/17504?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (acc5d62) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9e7953cd5ff901b5d19276108af6da2f0ae63c1f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e7953c) will **decrease** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17504      +/-   ##
   ============================================
   - Coverage     59.08%   58.98%   -0.11%     
   - Complexity     2114     2125      +11     
   ============================================
     Files          3550     3571      +21     
     Lines         53095    53221     +126     
     Branches       9058     9082      +24     
   ============================================
   + Hits          31372    31391      +19     
   - Misses        19080    19181     +101     
   - Partials       2643     2649       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...tor/format/facade/MySQLFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2Zvcm1hdC9mYWNhZGUvTXlTUUxGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
   | [...tor/format/facade/SQL92FormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL2Zvcm1hdC9mYWNhZGUvU1FMOTJGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
   | [...or/format/facade/OracleFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvZm9ybWF0L2ZhY2FkZS9PcmFjbGVGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
   | [...format/facade/OpenGaussFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3BlbmdhdXNzL3Zpc2l0b3IvZm9ybWF0L2ZhY2FkZS9PcGVuR2F1c3NGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
   | [...format/facade/SQLServerFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvZm9ybWF0L2ZhY2FkZS9TUUxTZXJ2ZXJGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
   | [...ormat/facade/PostgreSQLFormatSQLVisitorFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9mb3JtYXQvZmFjYWRlL1Bvc3RncmVTUUxGb3JtYXRTUUxWaXNpdG9yRmFjYWRlLmphdmE=) | `11.11% <0.00%> (-22.23%)` | :arrow_down: |
   | [...ck/standard/ShardingSphereStandardLockManager.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL3N0YW5kYXJkL1NoYXJkaW5nU3BoZXJlU3RhbmRhcmRMb2NrTWFuYWdlci5qYXZh) | `27.77% <0.00%> (-7.23%)` | :arrow_down: |
   | [...ne/spi/rulealtered/RuleAlteredDetectorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvc3BpL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkRGV0ZWN0b3JGYWN0b3J5LmphdmE=) | `60.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [...text/admin/DatabaseAdminBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL0RhdGFiYXNlQWRtaW5CYWNrZW5kSGFuZGxlckZhY3RvcnkuamF2YQ==) | `60.00% <0.00%> (-4.71%)` | :arrow_down: |
   | [...lock/global/general/ShardingSphereGeneralLock.java](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9sb2NrL2dsb2JhbC9nZW5lcmFsL1NoYXJkaW5nU3BoZXJlR2VuZXJhbExvY2suamF2YQ==) | `21.73% <0.00%> (-3.27%)` | :arrow_down: |
   | ... and [154 more](https://codecov.io/gh/apache/shardingsphere/pull/17504/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17504?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17504?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9e7953c...acc5d62](https://codecov.io/gh/apache/shardingsphere/pull/17504?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org