You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/01/21 22:03:55 UTC

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42362/
-----------------------------------------------------------

(Updated Jan. 21, 2016, 9:03 p.m.)

Review request for mesos, Michael Park and Neil Conway.

Changes
-------

Added another test with authorization enabled.

Summary (updated)
-----------------

Added persistent volume endpoint test without authentication.

Bugs: MESOS-4395
https://issues.apache.org/jira/browse/MESOS-4395

Repository: mesos

Description (updated)
-------

Added persistent volume endpoint tests with HTTP authentication disabled, both with and without authorization enabled.

The persistent volume endpoint tests allow volume creation and destruction without authorization and without a principal; this patch introduces test cases for this scenario: `PersistentVolumeEndpointsTest.NoAuthenticationNoAuthorization` and `PersistentVolumeEndpointsTest.NoAuthenticationWithAuthorization`. NOTE: due to the current behavior of the HTTP authentication code, when HTTP authentication is disabled, the endpoint callbacks always receive a principal of `None()`, which means that authorization cannot be properly used when HTTP authentication is disabled.

Diffs (updated)
-----

src/tests/persistent_volume_endpoints_tests.cpp 22e18758ee91a649486725473d9e50fae9d43b01

Diff: https://reviews.apache.org/r/42362/diff/

Testing
-------

A new test, `PersistentVolumeEndpointsTest.NoAuthorization`, was added to the persistent volume endpoint tests.

`make check` was used to test, and the new test was run with `--gtest_repeat=1000 -gtest_break_on_failure=1`.

Thanks,

Greg Mann