You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/25 18:18:17 UTC
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5223
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
While running fuzz-itest in dist-test with slow mode, asan, it's
often flaky due to timeouts. This test is the main culprit
as it often takes 13 minutes to complete.
This reduces the number of operations in this test and
'update_multiplier' to half, making it non-flaky.
Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/5223/1
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5223/2/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
Line 485: // TSAN builds run more slowly, so 1000 can cause timeouts.
500 can cause timeouts
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5223/2/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
Line 485: // TSAN builds run more slowly, so 1000 can cause timeouts.
> 500 can cause timeouts
Done
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
While running fuzz-itest in dist-test with slow mode, asan, it's
often flaky due to timeouts. This test is the main culprit
as it often takes 13 minutes to complete.
This reduces the number of operations in this test and
'update_multiplier' to half for all build types but TSAN (we had already
reduced ops in this case) making it non-flaky.
Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Reviewed-on: http://gerrit.cloudera.org:8080/5223
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Patch Set 1:
What I mention in the commit message is that I measured this in asan.
my guess is that this test will always some degree of flakyness (some roll of the dice might generate a fuzz batch with many slow operations) so makes sense to reduce the batches overall IMO.
Updated the commit message to reflect this.
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Patch Set 2:
> What I mention in the commit message is that I measured this in
> asan.
> my guess is that this test will always some degree of flakyness
> (some roll of the dice might generate a fuzz batch with many slow
> operations) so makes sense to reduce the batches overall IMO.
> Updated the commit message to reflect this.
Thank you for the clarification.
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5223
to look at the new patch set (#2).
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
While running fuzz-itest in dist-test with slow mode, asan, it's
often flaky due to timeouts. This test is the main culprit
as it often takes 13 minutes to complete.
This reduces the number of operations in this test and
'update_multiplier' to half for all build types but TSAN (we had already
reduced ops in this case) making it non-flaky.
Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/5223/2
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5223/1/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
PS1, Line 488: update_multiplier = 500
From the commit message, I thought the intention was to reduce number of mutations only for the ASAN builds.
However, in this case the number of mutations would decrease also for non-ASAN builds. If that was the original intention (i.e. reduce number of operations for _both_ ASAN and regular modes), it would be nice to reflect that in the commit message. If not, then may be it's worth updating this and add if/else involving the ADDRESS_SANITIZER macro?
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5223
to look at the new patch set (#3).
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
While running fuzz-itest in dist-test with slow mode, asan, it's
often flaky due to timeouts. This test is the main culprit
as it often takes 13 minutes to complete.
This reduces the number of operations in this test and
'update_multiplier' to half for all build types but TSAN (we had already
reduced ops in this case) making it non-flaky.
Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/5223/3
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No