[GitHub] [superset] pkdotson commented on a change in pull request #14048: refactor: Boostrap to AntD - Tabs

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #14048:
URL: https://github.com/apache/superset/pull/14048#discussion_r620846151



##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
##########
@@ -68,35 +67,29 @@ const DashboardContainer: FC<DashboardContainerProps> = ({
             the entire dashboard upon adding/removing top-level tabs, which would otherwise
             happen because of React's diffing algorithm
           */
-          <TabContainer
+          <Tabs
             id={DASHBOARD_GRID_ID}
-            activeKey={Math.min(tabIndex, childIds.length - 1)}
-            onSelect={handleChangeTab}
-            // @ts-ignore
-            animation
-            mountOnEnter
-            unmountOnExit={false}
+            activeKey={activeKey}
+            renderTabBar={() => <></>}

Review comment:
       Is this even needed if it's not rendering anything?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org