[GitHub] [flink] tillrohrmann commented on a change in pull request #18569: [FLINK-25847] Fix deadlock in DefaultMultipleComponentLeaderElectionService

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #18569:
URL: https://github.com/apache/flink/pull/18569#discussion_r795748839



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionServiceTest.java
##########
@@ -203,6 +206,68 @@ public void allKnownLeaderInformationCallsEventHandlers() throws Exception {
         }
     }
 
+    @Test
+    public void allKnownLeaderInformationDoesNotBlock() throws Exception {
+        final TestingMultipleComponentLeaderElectionDriver leaderElectionDriver =
+                TestingMultipleComponentLeaderElectionDriver.newBuilder().build();
+        final DefaultMultipleComponentLeaderElectionService leaderElectionService =
+                new DefaultMultipleComponentLeaderElectionService(
+                        fatalErrorHandlerExtension.getTestingFatalErrorHandler(),
+                        new TestingMultipleComponentLeaderElectionDriverFactory(
+                                leaderElectionDriver),
+                        java.util.concurrent.Executors.newSingleThreadScheduledExecutor());

Review comment:
       I think it is helpful to see where static methods come from. Therefore, I would not do this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org