[GitHub] [incubator-nuttx-apps] zhhyu7 commented on a diff in pull request #1425: wapi: fix save_config can not update if string prefix is same

[GitBox <gi...@apache.org>]

zhhyu7 commented on code in PR #1425:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1425#discussion_r1027227854


##########
wireless/wapi/src/util.c:
##########
@@ -148,7 +148,7 @@ static bool wapi_json_update(FAR cJSON *root,
           int len = strlen(obj->valuestring);
           if (len > 0)
             {
-              if (!strncmp(value, obj->valuestring, len))
+              if (!strcmp(value, obj->valuestring))

Review Comment:
   > could you please add spaces at line 159?
   
   Can you give me an example, Line 159 seems pretty normal to me...am I missing something？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org