You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/14 09:09:27 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #3108: Issue #3105: Optimize OrderedExecutor performance by using GrowableArrayBlockingQueue

eolivelli commented on a change in pull request #3108:
URL: https://github.com/apache/bookkeeper/pull/3108#discussion_r825723429



##########
File path: bookkeeper-common/src/main/java/org/apache/bookkeeper/common/collections/GrowableArrayBlockingQueue.java
##########
@@ -83,6 +82,7 @@ public T poll() {
         try {
             if (SIZE_UPDATER.get(this) > 0) {
                 T item = data[headIndex.value];
+                data[headIndex.value] = null;

Review comment:
       is there a test that cover this change ?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org