[GitHub] [spark] HyukjinKwon commented on a change in pull request #26282: [SPARK-29619] Add meaningful log and retry for start python worker process

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #26282: [SPARK-29619] Add meaningful log and retry for start python worker process
URL: https://github.com/apache/spark/pull/26282#discussion_r339524789
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala
 ##########
 @@ -206,15 +206,28 @@ private[spark] class PythonWorkerFactory(pythonExec: String, envVars: Map[String
         workerEnv.put("PYTHON_WORKER_FACTORY_SECRET", authHelper.secret)
         // This is equivalent to setting the -u flag; we use it because ipython doesn't support -u:
         workerEnv.put("PYTHONUNBUFFERED", "YES")
-        daemon = pb.start()
-
-        val in = new DataInputStream(daemon.getInputStream)
-        try {
-          daemonPort = in.readInt()
-        } catch {
-          case _: EOFException =>
-            throw new SparkException(s"No port number in $daemonModule's stdout")
 
 Review comment:
   Why don't you just fix exception message or adding an error level log? Seems confusing error doesn't justify retrying

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org