You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Steve Cohen <sc...@javactivity.org> on 2015/11/17 00:41:56 UTC
regex-property goal of build-helper-maven-plugin documentation is
incorrect
Documentation on the regex-property goal of build-helper-maven-plugin at
http://www.mojohaus.org/build-helper-maven-plugin/usage.html has an
error. This error has persisted for some time and has proliferated
around the Internet, for example in several Stack Overflow posts.
The error is this:
In the section marked "Set a property by applying a regex replacement to
a value",
under <configuration>, we see the <value> element exampled as
<value>$\{project.version}</value>
This is incorrect. The goal will fail if the backslash is included and
succeed if it is omitted. From my basic understanding of regex and of
Maven, it seemed wrong and I have verified that it is.
It's probably a typo, one that has confused some people, for example, on
Stack Overflow:
http://stackoverflow.com/questions/17516313/possible-bug-when-parsing-properties-with-goal-regex-property-of-build-helper
Can someone fix it?
Steve Cohen
Re: regex-property goal of build-helper-maven-plugin documentation is incorrect
Posted by Dan Tran <da...@gmail.com>.
Please verify the site at http://www.mojohaus.org/build-helper-maven-plugin/
I will call a vote to release 1.9.2 soon
Thanks
Dan
On Tue, Nov 17, 2015 at 12:54 PM, Dan Tran <da...@gmail.com> wrote:
> I will either push a new release out this weekend or update the site
>
> Thanks
>
> -Dan
>
> On Tue, Nov 17, 2015 at 10:21 AM, Alexander Kriegisch <
> alexander@kriegisch.name> wrote:
>
>> The site just hasn't been regenerated and uploaded, I guess?
>>
>>
>> Then I figure it is not really fixed. An unpublished documentation fix is
>> not worth a lot. Someone is lacking a Definition of Done here. ;-) Sorry
>> for being such a smart-ass, but I could not resist.
>> --
>> Alexander Kriegisch
>> http://scrum-master.de
>>
>>
>> Am 17.11.2015 um 04:54 schrieb Curtis Rueden <ct...@wisc.edu>:
>>
>> Hi Steve,
>>
>> Can someone fix it?
>>
>>
>> I was going to respond with "You can!" But it seems it was already fixed
>> almost a year ago:
>>
>>
>> https://github.com/mojohaus/build-helper-maven-plugin/commit/cdaa047253fdcb64f94e81a6e8575191b5919ab0
>>
>> The site just hasn't been regenerated and uploaded, I guess?
>>
>> -Curtis
>>
>> On Mon, Nov 16, 2015 at 5:41 PM, Steve Cohen <sc...@javactivity.org>
>> wrote:
>>
>> Documentation on the regex-property goal of build-helper-maven-plugin at
>>
>> http://www.mojohaus.org/build-helper-maven-plugin/usage.html has an
>>
>> error. This error has persisted for some time and has proliferated around
>>
>> the Internet, for example in several Stack Overflow posts.
>>
>>
>> The error is this:
>>
>>
>> In the section marked "Set a property by applying a regex replacement to a
>>
>> value",
>>
>> under <configuration>, we see the <value> element exampled as
>>
>>
>> <value>$\{project.version}</value>
>>
>>
>> This is incorrect. The goal will fail if the backslash is included and
>>
>> succeed if it is omitted. From my basic understanding of regex and of
>>
>> Maven, it seemed wrong and I have verified that it is.
>>
>>
>> It's probably a typo, one that has confused some people, for example, on
>>
>> Stack Overflow:
>>
>>
>>
>>
>> http://stackoverflow.com/questions/17516313/possible-bug-when-parsing-properties-with-goal-regex-property-of-build-helper
>>
>>
>> Can someone fix it?
>>
>>
>> Steve Cohen
>>
>>
>>
>
Re: regex-property goal of build-helper-maven-plugin documentation is incorrect
Posted by Dan Tran <da...@gmail.com>.
I will either push a new release out this weekend or update the site
Thanks
-Dan
On Tue, Nov 17, 2015 at 10:21 AM, Alexander Kriegisch <
alexander@kriegisch.name> wrote:
> The site just hasn't been regenerated and uploaded, I guess?
>
>
> Then I figure it is not really fixed. An unpublished documentation fix is
> not worth a lot. Someone is lacking a Definition of Done here. ;-) Sorry
> for being such a smart-ass, but I could not resist.
> --
> Alexander Kriegisch
> http://scrum-master.de
>
>
> Am 17.11.2015 um 04:54 schrieb Curtis Rueden <ct...@wisc.edu>:
>
> Hi Steve,
>
> Can someone fix it?
>
>
> I was going to respond with "You can!" But it seems it was already fixed
> almost a year ago:
>
>
> https://github.com/mojohaus/build-helper-maven-plugin/commit/cdaa047253fdcb64f94e81a6e8575191b5919ab0
>
> The site just hasn't been regenerated and uploaded, I guess?
>
> -Curtis
>
> On Mon, Nov 16, 2015 at 5:41 PM, Steve Cohen <sc...@javactivity.org>
> wrote:
>
> Documentation on the regex-property goal of build-helper-maven-plugin at
>
> http://www.mojohaus.org/build-helper-maven-plugin/usage.html has an
>
> error. This error has persisted for some time and has proliferated around
>
> the Internet, for example in several Stack Overflow posts.
>
>
> The error is this:
>
>
> In the section marked "Set a property by applying a regex replacement to a
>
> value",
>
> under <configuration>, we see the <value> element exampled as
>
>
> <value>$\{project.version}</value>
>
>
> This is incorrect. The goal will fail if the backslash is included and
>
> succeed if it is omitted. From my basic understanding of regex and of
>
> Maven, it seemed wrong and I have verified that it is.
>
>
> It's probably a typo, one that has confused some people, for example, on
>
> Stack Overflow:
>
>
>
>
> http://stackoverflow.com/questions/17516313/possible-bug-when-parsing-properties-with-goal-regex-property-of-build-helper
>
>
> Can someone fix it?
>
>
> Steve Cohen
>
>
>
Re: regex-property goal of build-helper-maven-plugin documentation is incorrect
Posted by Alexander Kriegisch <al...@kriegisch.name>.
> The site just hasn't been regenerated and uploaded, I guess?
Then I figure it is not really fixed. An unpublished documentation fix is not worth a lot. Someone is lacking a Definition of Done here. ;-) Sorry for being such a smart-ass, but I could not resist.
--
Alexander Kriegisch
http://scrum-master.de
> Am 17.11.2015 um 04:54 schrieb Curtis Rueden <ct...@wisc.edu>:
>
> Hi Steve,
>
>> Can someone fix it?
>
> I was going to respond with "You can!" But it seems it was already fixed
> almost a year ago:
>
> https://github.com/mojohaus/build-helper-maven-plugin/commit/cdaa047253fdcb64f94e81a6e8575191b5919ab0
>
> The site just hasn't been regenerated and uploaded, I guess?
>
> -Curtis
>
>> On Mon, Nov 16, 2015 at 5:41 PM, Steve Cohen <sc...@javactivity.org> wrote:
>>
>> Documentation on the regex-property goal of build-helper-maven-plugin at
>> http://www.mojohaus.org/build-helper-maven-plugin/usage.html has an
>> error. This error has persisted for some time and has proliferated around
>> the Internet, for example in several Stack Overflow posts.
>>
>> The error is this:
>>
>> In the section marked "Set a property by applying a regex replacement to a
>> value",
>> under <configuration>, we see the <value> element exampled as
>>
>> <value>$\{project.version}</value>
>>
>> This is incorrect. The goal will fail if the backslash is included and
>> succeed if it is omitted. From my basic understanding of regex and of
>> Maven, it seemed wrong and I have verified that it is.
>>
>> It's probably a typo, one that has confused some people, for example, on
>> Stack Overflow:
>>
>>
>> http://stackoverflow.com/questions/17516313/possible-bug-when-parsing-properties-with-goal-regex-property-of-build-helper
>>
>> Can someone fix it?
>>
>> Steve Cohen
>>
Re: regex-property goal of build-helper-maven-plugin documentation is incorrect
Posted by Curtis Rueden <ct...@wisc.edu>.
Hi Steve,
> Can someone fix it?
I was going to respond with "You can!" But it seems it was already fixed
almost a year ago:
https://github.com/mojohaus/build-helper-maven-plugin/commit/cdaa047253fdcb64f94e81a6e8575191b5919ab0
The site just hasn't been regenerated and uploaded, I guess?
-Curtis
On Mon, Nov 16, 2015 at 5:41 PM, Steve Cohen <sc...@javactivity.org> wrote:
> Documentation on the regex-property goal of build-helper-maven-plugin at
> http://www.mojohaus.org/build-helper-maven-plugin/usage.html has an
> error. This error has persisted for some time and has proliferated around
> the Internet, for example in several Stack Overflow posts.
>
> The error is this:
>
> In the section marked "Set a property by applying a regex replacement to a
> value",
> under <configuration>, we see the <value> element exampled as
>
> <value>$\{project.version}</value>
>
> This is incorrect. The goal will fail if the backslash is included and
> succeed if it is omitted. From my basic understanding of regex and of
> Maven, it seemed wrong and I have verified that it is.
>
> It's probably a typo, one that has confused some people, for example, on
> Stack Overflow:
>
>
> http://stackoverflow.com/questions/17516313/possible-bug-when-parsing-properties-with-goal-regex-property-of-build-helper
>
> Can someone fix it?
>
> Steve Cohen
>