Re: [PR] [SPARK-46683] Write a subquery generator that generates subqueries of different variations to increase testing coverage [spark]

["andylam-db (via GitHub)" <gi...@apache.org>]

andylam-db commented on PR #44599:
URL: https://github.com/apache/spark/pull/44599#issuecomment-1888079179

   @cloud-fan @jchen5 Open for reviews! I listed some potential issues in the PR description:
   
   > 1. There are a lot of queries. There are 14 files, each containing ~300 queries. Adding more variations (such as new operators like WINDOW, OFFSET) would only increase the number of queries. This might slow down tests significantly.
   > 2. A small change in the SubquerySQLGeneratorSuite might introduce a lot of golden file changes. This makes this potentially very difficult to maintain.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org