You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by mornindew <gi...@git.apache.org> on 2018/08/28 19:37:55 UTC

[GitHub] syncope pull request #83: Kubernetes Install

GitHub user mornindew opened a pull request:

    https://github.com/apache/syncope/pull/83

    Kubernetes Install

    The helm charts and instructions for how to install in Kubernetes.   This is a bare bones install and can be updated to include self healing and auto scaling.  It currently works with Postgres.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mornindew/syncope master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/syncope/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #83
    
----
commit 9af33863022334b1edbf4b5c686f937598ed420f
Author: Unknown <cr...@...>
Date:   2018-08-28T19:36:32Z

    Kubernetes Install 
    
    The helm charts and instructions for how to install in Kubernetes.   This is a bare bones install and can be updated to include self healing and auto scaling.  It currently works with Postgres

----


---

[GitHub] syncope issue #83: Kubernetes Install

Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/83
  
    Thanks for your contribution: see it on-line at https://ci.apache.org/projects/syncope/2_1_X/getting-started.html#kubernetes-sample
    
    As you can see, I did some minor editing and reflow.


---

[GitHub] syncope issue #83: Kubernetes Install

Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/83
  
    Thanks @mornindew 
    
    Could you please rebase your changes to latest `master` and squash your commits into one only? Thanks.
    
    And what about ICLA? Did you submit it?


---

[GitHub] syncope issue #83: Kubernetes Install

Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/83
  
    Please ensure that all new files contain the correct license header, or build will fail; for YAML, you can grab it from https://github.com/apache/syncope/blob/master/docker/src/main/resources/docker-compose-ha.yml - e.g. your YAML files should start with content:
    
    ```
    # Licensed to the Apache Software Foundation (ASF) under one
    # or more contributor license agreements.  See the NOTICE file
    # distributed with this work for additional information
    # regarding copyright ownership.  The ASF licenses this file
    # to you under the Apache License, Version 2.0 (the
    # "License"); you may not use this file except in compliance
    # with the License.  You may obtain a copy of the License at
    #
    #   http://www.apache.org/licenses/LICENSE-2.0
    #
    # Unless required by applicable law or agreed to in writing,
    # software distributed under the License is distributed on an
    # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    # KIND, either express or implied.  See the License for the
    # specific language governing permissions and limitations
    # under the License.
    
    ```


---

[GitHub] syncope issue #83: Kubernetes Install

Posted by mornindew <gi...@git.apache.org>.
Github user mornindew commented on the issue:

    https://github.com/apache/syncope/pull/83
  
    Made the recommended changes


---

[GitHub] syncope issue #83: Kubernetes Install

Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/83
  
    Thanks for this PR @mornindew - I'll review it in few days.
    Meanwhile: have you already submitted your ICLA? http://www.apache.org/licenses/#clas


---

[GitHub] syncope issue #83: Kubernetes Install

Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/83
  
    ping @mornindew 


---

[GitHub] syncope pull request #83: Kubernetes Install

Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/83#discussion_r214544229
  
    --- Diff: docker/src/main/resources/k8s/helm/README.adoc ---
    @@ -0,0 +1,22 @@
    += Install Commands
    +
    +Open a terminal and navigate to the "helm" folder.  **REMINDER:  SET YOUR VALUES.YAML!!!**
    --- End diff --
    
    Please substitute
    ```
    **REMINDER:  SET YOUR VALUES.YAML!!!**
    ```
    
    with
    
    ```
    [WARNING]
    Do not forget to set your `values.yaml`!
    ```


---

[GitHub] syncope pull request #83: Kubernetes Install

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/syncope/pull/83


---