[GitHub] [beam] pabloem commented on a change in pull request #15771: Enable BQ Standard SQL dialect style table specifications.

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #15771:
URL: https://github.com/apache/beam/pull/15771#discussion_r743081523



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -392,17 +392,15 @@ public static String toTableSpec(TableReference ref) {
 
   /**
    * Parse a table specification in the form {@code "[project_id]:[dataset_id].[table_id]"} or
-   * {@code "[dataset_id].[table_id]"}.
+   * {@code "[project_id].[dataset_id].[table_id]"} or {@code "[dataset_id].[table_id]"}.
    *
    * <p>If the project id is omitted, the default project id is used.
    */
   public static TableReference parseTableSpec(String tableSpec) {
     Matcher match = BigQueryIO.TABLE_SPEC.matcher(tableSpec);
     if (!match.matches()) {
       throw new IllegalArgumentException(
-          "Table reference is not in [project_id]:[dataset_id].[table_id] "
-              + "format: "
-              + tableSpec);
+          "Table reference is not in the expected " + "format: " + tableSpec);

Review comment:
       can you add the expected formats in the error message? so that users will receive actionable errors




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org