You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2019/12/09 21:21:09 UTC
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14870
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
IMPALA-9209: Fix flakiness in test_end_data_stream_error
TestRPCException.execute_test_query is a helper function that is used
by tests that set an RPC debug action to repeatedly run a query until
the debug action is hit.
Previously, it required that either the query is expected to always
succeed, or it must always fail if the debug action is hit and an
expected error is provided. However,the two tests that have an
expected error both set two debug actions - one that will cause a
query failure and one that won't (because we always retry 'reject too
busy' errors).
If only the debug action that doesn't cause query failure is hit, the
query won't fail and 'execute_test_query' will fail on the assert that
expects that the query must fail if the action was hit. This is rare,
as both debug actions have a high probability of being hit on a given
run of the query.
The solution is to remove the requirement from the tests that the
query must fail if an expected error is provided and the debug action
is hit.
Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
---
M tests/custom_cluster/test_rpc_exception.py
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/14870/1
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5233/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 21:51:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 21:54:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5240/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 17:24:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 2: Code-Review+2
carrying forward
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 16:55:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
IMPALA-9209: Fix flakiness in test_end_data_stream_error
TestRPCException.execute_test_query is a helper function that is used
by tests that set an RPC debug action to repeatedly run a query until
the debug action is hit.
Previously, it required that either the query is expected to always
succeed, or it must always fail if the debug action is hit and an
expected error is provided. However, the two tests that have an
expected error, test_end_data_stream_error and
test_transmit_data_error, both set two debug actions - one that will
cause a query failure and one that won't (because we always retry
'reject too busy' errors).
If only the debug action that doesn't cause query failure is hit, the
query won't fail and 'execute_test_query' will fail on the assert that
expects that the query must fail if the action was hit. This is rare,
as both debug actions have a high probability of being hit on a given
run of the query.
The solution is to remove the requirement from the tests that the
query must fail if an expected error is provided and the debug action
is hit.
Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Reviewed-on: http://gerrit.cloudera.org:8080/14870
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_rpc_exception.py
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 17:27:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG@15
PS1, Line 15: two test
> which two tests?
Done
http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG@15
PS1, Line 15: ,
> nit: missing space
Done
http://gerrit.cloudera.org:8080/#/c/14870/1/tests/custom_cluster/test_rpc_exception.py
File tests/custom_cluster/test_rpc_exception.py:
http://gerrit.cloudera.org:8080/#/c/14870/1/tests/custom_cluster/test_rpc_exception.py@78
PS1, Line 78: assert exception_string in str(e), "Query failed with unexpected exception."
> I think it would make this method a bit easier to read if this assert and t
Done
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 16:54:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Minor comments, otherwise LGTM.
http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG@15
PS1, Line 15: ,t
nit: missing space
http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG@15
PS1, Line 15: two tests
which two tests?
http://gerrit.cloudera.org:8080/#/c/14870/1/tests/custom_cluster/test_rpc_exception.py
File tests/custom_cluster/test_rpc_exception.py:
http://gerrit.cloudera.org:8080/#/c/14870/1/tests/custom_cluster/test_rpc_exception.py@78
PS1, Line 78: assert exception_string in str(e)
I think it would make this method a bit easier to read if this assert and the one below had a failure message e.g. `assert [condition], [failure-message]`.
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 15:28:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14870
to look at the new patch set (#2).
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
IMPALA-9209: Fix flakiness in test_end_data_stream_error
TestRPCException.execute_test_query is a helper function that is used
by tests that set an RPC debug action to repeatedly run a query until
the debug action is hit.
Previously, it required that either the query is expected to always
succeed, or it must always fail if the debug action is hit and an
expected error is provided. However, the two tests that have an
expected error, test_end_data_stream_error and
test_transmit_data_error, both set two debug actions - one that will
cause a query failure and one that won't (because we always retry
'reject too busy' errors).
If only the debug action that doesn't cause query failure is hit, the
query won't fail and 'execute_test_query' will fail on the assert that
expects that the query must fail if the action was hit. This is rare,
as both debug actions have a high probability of being hit on a given
run of the query.
The solution is to remove the requirement from the tests that the
query must fail if an expected error is provided and the debug action
is hit.
Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
---
M tests/custom_cluster/test_rpc_exception.py
1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/14870/2
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5328/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc
Gerrit-Change-Number: 14870
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 17:27:18 +0000
Gerrit-HasComments: No