You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/03/01 09:52:02 UTC

Review Request 65863: Updated mesos code with the new `os::system`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65863/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.


Bugs: MESOS-4549
    https://issues.apache.org/jira/browse/MESOS-4549


Repository: mesos


Description
-------

`os::system`'s return type was changed from `int` to `Option<int>`, so
the code in mesos was changed accordingly.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp 75b7eaf9cd62d6b5f02896175168b651f4517e12 
  src/tests/containerizer/cgroups_isolator_tests.cpp 59b23be78efb4025bfef53a19ab97d9873ab8dc9 
  src/tests/containerizer/memory_pressure_tests.cpp 0c3e738ce05553a2ee5c38c6748d6d28a1eb93d3 
  src/tests/environment.cpp 1cba274e0e684b123ce1e4d9cd296f428022fcdc 


Diff: https://reviews.apache.org/r/65863/diff/1/


Testing
-------


Thanks,

Akash Gupta

Re: Review Request 65863: Updated mesos code with the new `os::system`.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65863/#review198735
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On March 1, 2018, 1:52 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65863/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 1:52 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4549
>     https://issues.apache.org/jira/browse/MESOS-4549
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `os::system`'s return type was changed from `int` to `Option<int>`, so
> the code in mesos was changed accordingly.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp 75b7eaf9cd62d6b5f02896175168b651f4517e12 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 59b23be78efb4025bfef53a19ab97d9873ab8dc9 
>   src/tests/containerizer/memory_pressure_tests.cpp 0c3e738ce05553a2ee5c38c6748d6d28a1eb93d3 
>   src/tests/environment.cpp 1cba274e0e684b123ce1e4d9cd296f428022fcdc 
> 
> 
> Diff: https://reviews.apache.org/r/65863/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>