Re: [lang] Should IntRangeTest use variables fiveL, tenL?

[Stephen Colebourne <sc...@btopenworld.com>]

Looks like 

nr = new IntRange(fiveL, tenL);

is missing.

Stephen

----- Original Message ----- 
From: "Janek Bogucki" <ya...@studylink.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Wednesday, September 03, 2003 11:42 PM
Subject: [lang] Should IntRangeTest use variables fiveL, tenL?


> In IntRangeTest fiveL and tenL are assigned but not used. Should the
> code read:
> 
>         // test non Integer, for full coverage
>         Long fiveL = new Long(5L);
>         Long tenL = new Long(10L);
>         assertEquals(fiveL, nr.getMinimumNumber());
>         assertEquals(tenL, nr.getMaximumNumber());
> 
> This is the current version of the method in question:
> 
>     public void testConstructor2b() {
>         IntRange nr = new IntRange(five, ten);
>         assertSame(five, nr.getMinimumNumber());
>         assertSame(ten, nr.getMaximumNumber());
>         
>         nr = new IntRange(ten, five);
>         assertSame(five, nr.getMinimumNumber());
>         assertSame(ten, nr.getMaximumNumber());
>         
>         nr = new IntRange(five, long10);
>         assertSame(five, nr.getMinimumNumber());
>         assertEquals(ten, nr.getMaximumNumber());
>         
>         // test non Integer, for full coverage
>         Long fiveL = new Long(5L);
>         Long tenL = new Long(10L);
>         assertEquals(five, nr.getMinimumNumber());
>         assertEquals(ten, nr.getMaximumNumber());
>         
>         // not null
>         try {
>             new IntRange(five, null);
>             fail();
>         } catch (IllegalArgumentException ex) {}
>         try {
>             new IntRange(null, five);
>             fail();
>         } catch (IllegalArgumentException ex) {}
>         try {
>             new IntRange(null, null);
>             fail();
>         } catch (IllegalArgumentException ex) {}
>     }
> 
> -Janek
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 

Re: [lang] Should IntRangeTest use variables fiveL, tenL?

[Phil Steitz <ph...@steitz.com>]

Stephen Colebourne wrote:
> Looks like 
> 
> nr = new IntRange(fiveL, tenL);
> 
> is missing.
> 
> Stephen
> 


Yes.  Fixed now in CVS.  Path coverage is now 100%.

Thanks, Janek.

Phil