You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "aloyszhang (via GitHub)" <gi...@apache.org> on 2023/05/16 08:47:40 UTC

[GitHub] [bookkeeper] aloyszhang commented on a diff in pull request #3329: Fix data lost when configured multiple ledger directories

aloyszhang commented on code in PR #3329:
URL: https://github.com/apache/bookkeeper/pull/3329#discussion_r1194830852


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java:
##########
@@ -872,6 +869,9 @@ int shutdown(int exitCode) {
                 // Shutdown the EntryLogger which has the GarbageCollector Thread running
                 ledgerStorage.shutdown();
 
+                // Shutdown Sync thread
+                syncThread.shutdown();

Review Comment:
   Here may through exceptions when shutdown the `syncThread` which will call `checkpoint`  of ledgerStoreage, since we have already shut down the ledgeerStorage before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org