You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/11/28 21:31:55 UTC
Review Request 64136: Introduced an allocator helper function to
track used resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64136/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Jie Yu.
Repository: mesos
Description
-------
This patch introduces a helper to track allocated resources. It
encapsulates all needed updates to the various sorters for
reusability.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3
src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b
Diff: https://reviews.apache.org/r/64136/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64136: Introduced an allocator helper function to
track used resources.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64136/#review192390
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp
Lines 1902-1910 (original), 1855-1863 (patched)
<https://reviews.apache.org/r/64136/#comment270498>
Can we leverage the tracking code for this as well? This code to me is:
```
// Allocate it:
slave.allocated += resources;
// Track the allocation:
trackAllocation(...);
```
Although it's a little unclear to me why the updating of slave.allocated isn't done in the function? Is that not part of tracking an allocation?
- Benjamin Mahler
On Nov. 29, 2017, 4:27 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64136/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a helper to track allocated resources. It
> encapsulates all needed updates to the various sorters for
> reusability.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3
> src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b
>
>
> Diff: https://reviews.apache.org/r/64136/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64136: Introduced an allocator helper function to
track used resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64136/#review192227
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 29, 2017, 4:27 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64136/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a helper to track allocated resources. It
> encapsulates all needed updates to the various sorters for
> reusability.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3
> src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b
>
>
> Diff: https://reviews.apache.org/r/64136/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64136: Introduced an allocator helper function to
track used resources.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64136/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 5:27 p.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Addressed comment from bmahler (used helper in another place); simplified helper.
Repository: mesos
Description
-------
This patch introduces a helper to track allocated resources. It
encapsulates all needed updates to the various sorters for
reusability.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3
src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b
Diff: https://reviews.apache.org/r/64136/diff/2/
Changes: https://reviews.apache.org/r/64136/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64136: Introduced an allocator helper function to
track used resources.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Nov. 29, 2017, 12:54 a.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 284-304 (original), 284-304 (patched)
> > <https://reviews.apache.org/r/64136/diff/1/?file=1902750#file1902750line284>
> >
> > There is similar code for tracking the allocation, this is another spot, is there any reason for not calling into it here?
Good catch.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64136/#review192078
-----------------------------------------------------------
On Nov. 29, 2017, 5:27 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64136/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 5:27 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a helper to track allocated resources. It
> encapsulates all needed updates to the various sorters for
> reusability.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3
> src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b
>
>
> Diff: https://reviews.apache.org/r/64136/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64136: Introduced an allocator helper function to
track used resources.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64136/#review192078
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp
Lines 284-304 (original), 284-304 (patched)
<https://reviews.apache.org/r/64136/#comment270093>
There is similar code for tracking the allocation, this is another spot, is there any reason for not calling into it here?
- Benjamin Mahler
On Nov. 28, 2017, 9:31 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64136/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2017, 9:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces a helper to track allocated resources. It
> encapsulates all needed updates to the various sorters for
> reusability.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3
> src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b
>
>
> Diff: https://reviews.apache.org/r/64136/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>