[GitHub] [skywalking] wyt commented on pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.

[GitBox <gi...@apache.org>]

wyt commented on PR #8945:
URL: https://github.com/apache/skywalking/pull/8945#issuecomment-1108648966

   > Ww discussed about this before, 2 things
   > 
   > 1. Use this setup means you have known what to do, and what does this setup mean
   > 2. Use the first IP address doesn't change the fact it still could be wrong. A little approvement, but not much
   > 
   > And from the code perspective, if this is going to be accepted, we have to change all cluster manager implementations, besides k8s as it is automatically working.
   
   The automatic setting solves the problem in most cases, in a few cases it can be set manually, you are correct, need to change all cluster manager implementations, I didn't realize this at first. It is recommended that the official make a unified improvement on this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org