[jira] [Commented] (HBASE-12437) HLogFactory should load default WAL reader if custom user WAL reader fails instead of throwing InvalidProtocolBufferReaderException

["Enoch Hsu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200775#comment-14200775 ] 

Enoch Hsu commented on HBASE-12437:
-----------------------------------

It's failing with an invalid wire type

com.google.protobuf.InvalidProtocolBufferException: Protocol message tag had invalid wire type.
at com.google.protobuf.InvalidProtocolBufferException.invalidWireType(InvalidProtocolBufferException.java:99)
at com.google.protobuf.UnknownFieldSet$Builder.mergeFieldFrom(UnknownFieldSet.java:498)
at com.google.protobuf.GeneratedMessage.parseUnknownField(GeneratedMessage.java:193)

> HLogFactory should load default WAL reader if custom user WAL reader fails instead of throwing InvalidProtocolBufferReaderException
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12437
>                 URL: https://issues.apache.org/jira/browse/HBASE-12437
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.96.0, 0.98.4
>            Reporter: Enoch Hsu
>            Assignee: Enoch Hsu
>             Fix For: 1.0.0, 0.98.4
>
>
> The HLogFactory createReader function allows the user to create their own reader and just assumes that the reader will work correctly.
> In the case the user accidentally uses an incorrect reader and gets an InvalidProtocolBufferReaderException, HBase should have a safeguard to still allow HBase functions to execute.
> I propose that in this case HBase should default to the standard HBase readers.(ProtobufLogReader or  SequenceFIleLogReader)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)