You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/09 18:48:00 UTC

[jira] [Commented] (AIRFLOW-7019) Add visual indication of failure to pause/unpause a dag

    [ https://issues.apache.org/jira/browse/AIRFLOW-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055300#comment-17055300 ] 

ASF GitHub Bot commented on AIRFLOW-7019:
-----------------------------------------

jmcarp commented on pull request #7669: [AIRFLOW-7019] Show un/pause errors in dags view.
URL: https://github.com/apache/airflow/pull/7669
 
 
   Pausing and unpausing dags in the dags view is asynchronous, and there
   is currently no indication to the user if the operation fails. This
   patch updates the paused input and highlights it in red when pausing or
   unpausing fails.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add visual indication of failure to pause/unpause a dag
> -------------------------------------------------------
>
>                 Key: AIRFLOW-7019
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-7019
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: webserver
>    Affects Versions: 1.10.9
>            Reporter: Joshua Carp
>            Assignee: Joshua Carp
>            Priority: Minor
>
> Pausing and unpausing dags from the dag list view is asynchronous, and if the request fails for any reason, there's no indication to the user that the dag hasn't actually changed status. I noticed this recently when cloud composer pushed an update that broke all dag pausing and unpausing, but there are other reasons this could fail. A failed un/pause request should show an indication that the operation failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)