You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "wardlican (via GitHub)" <gi...@apache.org> on 2025/04/16 02:16:32 UTC
[PR] [Bug]: The flink optimizer often triggers OOM exceptions. In fact, th… [amoro]
wardlican opened a new pull request, #3521:
URL: https://github.com/apache/amoro/pull/3521
…e files processed by each task are not large. #3502
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #xxx.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3521:
URL: https://github.com/apache/amoro/pull/3521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3521:
URL: https://github.com/apache/amoro/pull/3521#issuecomment-2808081421
Thanks for the contribution!
It seems that some check style error you need to fix, you can run `mvn spotless:apply` in the root directory to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3521:
URL: https://github.com/apache/amoro/pull/3521#issuecomment-2814953881
> For data process task, maybe user thread is a better choice? WDYT @zhoujinsong
Setting the thread to daemon looks good to me. The process handling thread should not protect the TM from closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug]: The flink optimizer often triggers OOM exceptions. In fact, th… [amoro]
Posted by "Aireed (via GitHub)" <gi...@apache.org>.
Aireed commented on PR #3521:
URL: https://github.com/apache/amoro/pull/3521#issuecomment-2808053021
您能否按照 PR 规范修改信息？您可以参考 https://github.com/apache/amoro/pull/3432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. [amoro]
Posted by "wardlican (via GitHub)" <gi...@apache.org>.
wardlican commented on PR #3521:
URL: https://github.com/apache/amoro/pull/3521#issuecomment-2809275330
> Can you explain this change. Why make the thread be a daemon thread
This design not only ensures graceful exit during normal shutdown, but also provides an additional safety guarantee through the characteristics of daemon threads to prevent threads from preventing JVM exit under abnormal circumstances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug]: The flink optimizer often triggers OOM exceptions. In fact, the files processed by each task are not large. [amoro]
Posted by "XBaith (via GitHub)" <gi...@apache.org>.
XBaith commented on PR #3521:
URL: https://github.com/apache/amoro/pull/3521#issuecomment-2811583722
> This design not only ensures graceful exit during normal shutdown, but also provides an additional safety guarantee through the characteristics of daemon threads to prevent threads from preventing JVM exit under abnormal circumstances.
For data process task, maybe user thread is a better choice? WDYT @zhoujinsong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org