You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/11 09:08:50 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #10186: GenericObject: handle KeyValue with SEPARATED encoding and add more tests

eolivelli opened a new pull request #10186:
URL: https://github.com/apache/pulsar/pull/10186


   Motivations:
   When you are using SEPARATED KeyEncoding Message#getValue() must return a GenericObject wrapper, before this patch it returned a raw KeyValue, leading to a ClassCastException on the Consumer.
   
   Modifications:
   - handle KeyValue with SEPARATED key encoding in MessageImpl
   - add more test about GenericObject + KeyValue: INLINE/SEPARATED, primitives/structs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #10186: GenericObject: handle KeyValue with SEPARATED encoding and add more tests

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10186:
URL: https://github.com/apache/pulsar/pull/10186#issuecomment-817319353


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #10186: GenericObject: handle KeyValue with SEPARATED encoding and add more tests

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10186:
URL: https://github.com/apache/pulsar/pull/10186


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org