You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/21 23:51:20 UTC

[GitHub] [hudi] nsivabalan opened a new pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

nsivabalan opened a new pull request #4413:
URL: https://github.com/apache/hudi/pull/4413


   ## What is the purpose of the pull request
   
   - Add config to ignore files with certain prefix. 
   - Fix max msgs consumed per batch in S3Source as configurable. 
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan closed pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #4413:
URL: https://github.com/apache/hudi/pull/4413


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#issuecomment-999172404


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 702a1e40c4e0d42a78ba9fb716e80b418bbd7e59 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#issuecomment-999173363


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4644",
       "triggerID" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 702a1e40c4e0d42a78ba9fb716e80b418bbd7e59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4644) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#issuecomment-999173363


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4644",
       "triggerID" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 702a1e40c4e0d42a78ba9fb716e80b418bbd7e59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4644) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on a change in pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#discussion_r773559076



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -110,6 +113,9 @@ public S3EventsHoodieIncrSource(
     if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_KEY_PREFIX))) {
       filter = filter + " and s3.object.key like '" + props.getString(Config.S3_KEY_PREFIX) + "%'";
     }
+    if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_IGNORE_KEY_PREFIX))) {

Review comment:
       will add the tests once https://github.com/apache/hudi/pull/4334 gets merged. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#issuecomment-999172404


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 702a1e40c4e0d42a78ba9fb716e80b418bbd7e59 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#issuecomment-999200967


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4644",
       "triggerID" : "702a1e40c4e0d42a78ba9fb716e80b418bbd7e59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 702a1e40c4e0d42a78ba9fb716e80b418bbd7e59 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4644) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on a change in pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#discussion_r773511174



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -110,6 +113,9 @@ public S3EventsHoodieIncrSource(
     if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_KEY_PREFIX))) {
       filter = filter + " and s3.object.key like '" + props.getString(Config.S3_KEY_PREFIX) + "%'";
     }
+    if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_IGNORE_KEY_PREFIX))) {

Review comment:
       apparently S3 incremental source does not have good tests. I have filed a tracking jira [here](https://issues.apache.org/jira/browse/HUDI-3089). Will take it as a follow up. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #4413: [HUDI-3009] Making some fixes to S3 incremental source

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4413:
URL: https://github.com/apache/hudi/pull/4413#issuecomment-999171365


   @harsh1231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org