You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/08 02:08:34 UTC

[GitHub] [spark] beliefer commented on a change in pull request #24313: [SPARK-27402][SQL][TEST] Support HiveExternalCatalog backward compatibility test

beliefer commented on a change in pull request #24313: [SPARK-27402][SQL][TEST] Support HiveExternalCatalog backward compatibility test
URL: https://github.com/apache/spark/pull/24313#discussion_r272867519
 
 

 ##########
 File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
 ##########
 @@ -196,6 +196,8 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {
       "--name", "HiveExternalCatalog backward compatibility test",
       "--master", "local[2]",
       "--conf", "spark.ui.enabled=false",
+      "--conf", "spark.sql.hive.metastore.version=1.2.1",
 
 Review comment:
   The default value of `spark.sql.hive.metastore.jars` is 1.2.1. Why you need to add this config?
   According to the description of this PR, there should be 2.3.4 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org