You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/02 20:16:57 UTC
[GitHub] [spark] ueshin commented on a change in pull request #33850: [SPARK-36531][SPARK-36515][PYTHON] Improve test coverage for data_type_ops/* and groupby.
ueshin commented on a change in pull request #33850:
URL: https://github.com/apache/spark/pull/33850#discussion_r701388239
##########
File path: python/pyspark/pandas/tests/data_type_ops/test_categorical_ops.py
##########
@@ -190,6 +190,7 @@ def test_astype(self):
self.assert_eq(pser.astype(str), psser.astype(str))
self.assert_eq(pser.astype(bool), psser.astype(bool))
self.assert_eq(pser.astype("category"), psser.astype("category"))
+ self.assert_eq(pser.astype("category"), psser.astype("category"))
Review comment:
This is duplicated with the previous one?
##########
File path: python/pyspark/pandas/tests/data_type_ops/test_datetime_ops.py
##########
@@ -191,10 +191,11 @@ def test_astype(self):
pser = self.pser
psser = self.psser
self.assert_eq(pser.astype(str), psser.astype(str))
- self.assert_eq(pser.astype("category"), psser.astype("category"))
Review comment:
Why is this removed?
##########
File path: python/pyspark/pandas/tests/data_type_ops/test_string_ops.py
##########
@@ -24,7 +24,9 @@
from pyspark import pandas as ps
from pyspark.pandas.config import option_context
from pyspark.pandas.tests.data_type_ops.testing_utils import TestCasesUtils
-from pyspark.pandas.typedef.typehints import extension_object_dtypes_available
+from pyspark.pandas.typedef.typehints import (
+ extension_object_dtypes_available,
+)
Review comment:
This is an unrelated change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org