You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2016/05/17 12:20:29 UTC
Review Request 47451: RANGER-964: Fix NOTICE and LICENSE file contents
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47451/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Repository: ranger
Description
-------
Add missing licenses to LICENSE file
Diffs
-----
LICENSE.txt 7d2eff7
Diff: https://reviews.apache.org/r/47451/diff/
Testing
-------
Thanks,
Gautam Borad
Re: Review Request 47451: RANGER-964: Fix NOTICE and LICENSE file
contents
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47451/#review133543
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 17, 2016, 2:32 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47451/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 2:32 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-964
> https://issues.apache.org/jira/browse/RANGER-964
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Add missing licenses to LICENSE file
>
>
> Diffs
> -----
>
> LICENSE.txt 7d2eff7
> NOTICE.txt 3130ce2
>
> Diff: https://reviews.apache.org/r/47451/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 47451: RANGER-964: Fix NOTICE and LICENSE file
contents
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47451/
-----------------------------------------------------------
(Updated May 17, 2016, 2:32 p.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-964
https://issues.apache.org/jira/browse/RANGER-964
Repository: ranger
Description
-------
Add missing licenses to LICENSE file
Diffs (updated)
-----
LICENSE.txt 7d2eff7
NOTICE.txt 3130ce2
Diff: https://reviews.apache.org/r/47451/diff/
Testing
-------
Thanks,
Gautam Borad
Re: Review Request 47451: RANGER-964: Fix NOTICE and LICENSE file
contents
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47451/
-----------------------------------------------------------
(Updated May 17, 2016, 2:15 p.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Thanks Vel for pointing out. Have fixed it in this patch.
Bugs: RANGER-964
https://issues.apache.org/jira/browse/RANGER-964
Repository: ranger
Description
-------
Add missing licenses to LICENSE file
Diffs (updated)
-----
LICENSE.txt 7d2eff7
NOTICE.txt b30f645
Diff: https://reviews.apache.org/r/47451/diff/
Testing
-------
Thanks,
Gautam Borad
Re: Review Request 47451: RANGER-964: Fix NOTICE and LICENSE file
contents
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47451/#review133535
-----------------------------------------------------------
Fix it, then Ship it!
Fix, then Ship!
LICENSE.txt (line 317)
<https://reviews.apache.org/r/47451/#comment198002>
@Gautam - Can you fix these issues?
1] Following are repeated in NOTICE.txt and should be removed from there.
This product includes Bootstrap Datepicker (http://www.eyecon.ro/bootstrap-datepicker - Apache License - 2.0), Copyright 2012 Stefan Petre.
This product includes bootstrap-transition.js v2.3.2 (http://twbs.github.com/bootstrap/javascript.html#transitions - Apache License - 2.0), Copyright 2013 Twitter, Inc.
This product includes Select2 3.4.3 (http://ivaynberg.github.io/select2/ - Apache License - 2.0), Copyright 2012 Igor Vaynberg.
This product includes VisualSearch.js 0.4.0 (http://documentcloud.github.com/visualsearch), � 2011 Samuel Clay, @samuelclay, DocumentCloud Inc.
This product includes Require.js Handlebars Plugin (https://github.com/SlexAxton/require-handlebars-plugin - WTFPL + requirejs + handlebars), Copyright � 2011-2014 by Yehuda Katz.
2] Following should be removed from NOTICE.txt and added in LICENSE.txt
This product includes jQuery Pines Notify (pnotify) Plugin 1.2.0 (http://sciactive.com/pnotify/- MPL), Copyright � 2009-2012 Hunter Perrin.
3] Confirm the below are covered in jqeury globalize license.
-- security-admin/src/main/webapp/libs/bower/globalize/generator/HijriCalendar.js
-- security-admin/src/main/webapp/libs/bower/globalize/generator/StringExt.cs
-- security-admin/src/main/webapp/libs/bower/globalize/generator/UmAlQuraCalendar.js
- Velmurugan Periasamy
On May 17, 2016, 12:21 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47451/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 12:21 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-964
> https://issues.apache.org/jira/browse/RANGER-964
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Add missing licenses to LICENSE file
>
>
> Diffs
> -----
>
> LICENSE.txt 7d2eff7
>
> Diff: https://reviews.apache.org/r/47451/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 47451: RANGER-964: Fix NOTICE and LICENSE file
contents
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47451/
-----------------------------------------------------------
(Updated May 17, 2016, 12:21 p.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-964
https://issues.apache.org/jira/browse/RANGER-964
Repository: ranger
Description
-------
Add missing licenses to LICENSE file
Diffs
-----
LICENSE.txt 7d2eff7
Diff: https://reviews.apache.org/r/47451/diff/
Testing
-------
Thanks,
Gautam Borad