You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by kjmrknsn <gi...@git.apache.org> on 2017/09/25 12:13:06 UTC

[GitHub] zeppelin pull request #2598: Support Ceph as a notebook storage

GitHub user kjmrknsn opened a pull request:

    https://github.com/apache/zeppelin/pull/2598

    Support Ceph as a notebook storage

    ### What is this PR for?
    Make Zeppelin support Ceph as a notebook storage.
    
    Ceph has APIs which are compatible with AWS S3 APIs. However, it supports only AWS Signature V2 and GetObject requests of aws-sdk-java use V4 by default: https://github.com/aws/aws-sdk-java/issues/372
    
    According to https://github.com/aws/aws-sdk-java/issues/372#issuecomment-137299691 , the Zeppelin configuration of `zeppelin.notebook.s3.signerOverride` is added to make the `signerOverride` field of a `ClientConfiguration` instance configurable.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2950
    
    ### How should this be tested?
    Tested manually.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjmrknsn/zeppelin feature/ceph-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2598
    
----
commit 0fadb86db8055ee34d5bf401bedc3ceff3183d58
Author: Keiji Yoshida <kj...@gmail.com>
Date:   2017-09-25T12:03:54Z

    Support Ceph as a notebook storage

----


---

[GitHub] zeppelin issue #2598: [ZEPPELIN-2950] Support Ceph as a notebook storage

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2598
  
    CI failure looks unrelated to this.
    
    LGTM and merge to master if no further review.
    Thanks again @kjmrknsn for the contribution.


---

[GitHub] zeppelin issue #2598: [ZEPPELIN-2950] Support Ceph as a notebook storage

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2598
  
    Thanks @kjmrknsn for the contribution!
    
    Could you also update https://github.com/apache/zeppelin/blob/master/docs/setup/operation/configuration.md#zeppelin-properties ?


---

[GitHub] zeppelin pull request #2598: [ZEPPELIN-2950] Support Ceph as a notebook stor...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2598


---

[GitHub] zeppelin issue #2598: [ZEPPELIN-2950] Support Ceph as a notebook storage

Posted by kjmrknsn <gi...@git.apache.org>.

Github user kjmrknsn commented on the issue:

    https://github.com/apache/zeppelin/pull/2598
  
    @Leemoonsoo Thanks for your review. I added the property of `ZEPPELIN_NOTEBOOK_S3_SIGNEROVERRIDE` to configuration.md: https://github.com/apache/zeppelin/pull/2598/files#diff-d86fb0bb17c918e22cb888ebfe0ff1cc
    
    (Commits were squashed.)


---