You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/24 07:04:44 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #11034: style: clickable labels have outlines, storybook shows them
rusackas opened a new pull request #11034:
URL: https://github.com/apache/incubator-superset/pull/11034
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Touches up the Label component in a few ways:
• Labels get a visible border if they have an onClick handler. No border if they don't.
• Default label gets a lighter/inverted color treatment (colors copped from https://github.com/apache/incubator-superset/pull/10971)
• Adds a row to the Storybook to show both interactive and non-interactive variants
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Storybook FTW.
Stamp of approval from @steejay
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #11034: style: clickable labels have outlines, storybook shows them
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11034:
URL: https://github.com/apache/incubator-superset/pull/11034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #11034: style: clickable labels have outlines, storybook shows them
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11034:
URL: https://github.com/apache/incubator-superset/pull/11034#issuecomment-698704701
Merging so that I can rebase https://github.com/apache/incubator-superset/pull/10971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #11034: style: clickable labels have outlines, storybook shows them
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11034:
URL: https://github.com/apache/incubator-superset/pull/11034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #11034: style: clickable labels have outlines, storybook shows them
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11034:
URL: https://github.com/apache/incubator-superset/pull/11034#issuecomment-698704701
Merging so that I can rebase https://github.com/apache/incubator-superset/pull/10971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org