[GitHub] [hive] pvary commented on a diff in pull request #3204: HIVE-26136: Implement UPDATE statements for Iceberg tables

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3204:
URL: https://github.com/apache/hive/pull/3204#discussion_r865027643


##########
iceberg/iceberg-handler/src/test/queries/positive/update_iceberg_unpartitioned_parquet.q:
##########
@@ -0,0 +1,26 @@
+drop table if exists tbl_ice;
+create external table tbl_ice(a int, b string, c int) stored by iceberg tblproperties ('format-version'='2');
+
+-- update using simple predicates
+insert into tbl_ice values (1, 'one', 50), (2, 'two', 51), (3, 'three', 52), (4, 'four', 53), (5, 'five', 54), (111, 'one', 55), (333, 'two', 56);
+update tbl_ice set b='Changed' where b in ('one', 'four') or a = 22;

Review Comment:
   Added unit tests for that.
   Thanks for the idea, actually found some issues when the tests were run!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org