You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by MCyprien <gi...@git.apache.org> on 2015/02/23 15:45:12 UTC
[GitHub] couchdb pull request: Update Dockerfile
GitHub user MCyprien opened a pull request:
https://github.com/apache/couchdb/pull/305
Update Dockerfile
Add nodejs and npm for Fauxton
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MCyprien/couchdb patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #305
----
commit 6a5097e75b49120183505f60254eda9bf8c0e4e2
Author: MCyprien <ma...@hotmail.fr>
Date: 2015-02-23T14:44:41Z
Update Dockerfile
Add nodejs and npm for Fauxton
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/305#discussion_r25244080
--- Diff: Dockerfile ---
@@ -18,6 +18,10 @@ RUN apt-get --no-install-recommends -y install \
libmozjs185-dev \
python
+# Install Nodejs
+RUN curl -sL https://deb.nodesource.com/setup | bash -
--- End diff --
#facepalm, that’s a great idea. — Let’s see if @klaemo is up for contributing his work :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/305#discussion_r25176762
--- Diff: Dockerfile ---
@@ -18,6 +18,10 @@ RUN apt-get --no-install-recommends -y install \
libmozjs185-dev \
python
+# Install Nodejs
+RUN curl -sL https://deb.nodesource.com/setup | bash -
--- End diff --
+1, we should do what the script does directly, not download it first. It is MIT licensed, we could keep a local copy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/305#discussion_r25243962
--- Diff: Dockerfile ---
@@ -18,6 +18,10 @@ RUN apt-get --no-install-recommends -y install \
libmozjs185-dev \
python
+# Install Nodejs
+RUN curl -sL https://deb.nodesource.com/setup | bash -
--- End diff --
or we could just borrow a few bits from https://github.com/klaemo/docker-couchdb/blob/master/2.0-dev/Dockerfile#L32-L35 if @klaemo don't mind (:
P.S. @janl, another question is a reason to maintain our Dockerfile when @klaemo keep his well. May be we could unite our effort on this with Clemens instead of doing the same work twice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by MCyprien <gi...@git.apache.org>.
Github user MCyprien commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/305#discussion_r25242419
--- Diff: Dockerfile ---
@@ -18,6 +18,10 @@ RUN apt-get --no-install-recommends -y install \
libmozjs185-dev \
python
+# Install Nodejs
+RUN curl -sL https://deb.nodesource.com/setup | bash -
--- End diff --
Hello everyone,
Nice to have feed back :D.
I found it in http://nodejs.org/download/ there is a link "Installing from package managers" so I took it . I thought it was a good think.
Sorry if I did something wrong
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by klaemo <gi...@git.apache.org>.
Github user klaemo commented on the pull request:
https://github.com/apache/couchdb/pull/305#issuecomment-166319578
This is being worked on in apache/couchdb#340, so this PR can be closed, I'd say.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/305#discussion_r25170368
--- Diff: Dockerfile ---
@@ -18,6 +18,10 @@ RUN apt-get --no-install-recommends -y install \
libmozjs185-dev \
python
+# Install Nodejs
+RUN curl -sL https://deb.nodesource.com/setup | bash -
--- End diff --
I feel cold for blindly executing arbitrary shell script. Isn't there a more secure and explicit way to add those repository?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/305#discussion_r25244181
--- Diff: Dockerfile ---
@@ -18,6 +18,10 @@ RUN apt-get --no-install-recommends -y install \
libmozjs185-dev \
python
+# Install Nodejs
+RUN curl -sL https://deb.nodesource.com/setup | bash -
--- End diff --
https://github.com/klaemo/docker-couchdb/issues/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Update Dockerfile
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/305#discussion_r25243636
--- Diff: Dockerfile ---
@@ -18,6 +18,10 @@ RUN apt-get --no-install-recommends -y install \
libmozjs185-dev \
python
+# Install Nodejs
+RUN curl -sL https://deb.nodesource.com/setup | bash -
--- End diff --
@MCyprien you didn’t do anything wrong, no worries! :)
It’s just that we have to think about beyond just having someone interactively installing Node.js for CouchDB, hence our comments.
The best way forward would be to import the file as a dependency (needs an update in the NOTICE and LICENSE files) and then call it locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request #305: Update Dockerfile
Posted by wohali <gi...@git.apache.org>.
Github user wohali closed the pull request at:
https://github.com/apache/couchdb/pull/305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---