You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/09/06 12:40:16 UTC
[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1403:
[issue #1400]do disk space detection in another thread
duhenglucky commented on a change in pull request #1403: [issue #1400]do disk space detection in another thread
URL: https://github.com/apache/rocketmq/pull/1403#discussion_r315966978
##########
File path: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -1261,6 +1264,11 @@ public void run() {
// DefaultMessageStore.this.cleanExpiredConsumerQueue();
// }
// }, 1, 1, TimeUnit.HOURS);
+ this.diskCheckScheduledExecutorService.scheduleAtFixedRate(new Runnable() {
Review comment:
It would be better to shut down this scheduled service when the server closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services