You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/02/26 19:28:43 UTC

[GitHub] [incubator-heron] joshfischer1108 opened a new pull request #3778: Joshfischer/3774/pom dependencies

joshfischer1108 opened a new pull request #3778:
URL: https://github.com/apache/incubator-heron/pull/3778


   Does this list the necessary deps?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3778: Joshfischer/3774/pom dependencies

Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3778:
URL: https://github.com/apache/incubator-heron/pull/3778#issuecomment-1052575367


   > The pom.xml templates are used to generate pom files for various artifacts. Not sure if this scripts needs to be changed. For example, are the dependencies the same for heron-api and heron-spi? https://github.com/apache/incubator-heron/blob/master/release/maven/maven-pom-version.sh
   > 
   > Edit: [This script](https://github.com/apache/incubator-heron/blob/master/scripts/ci/build_maven_artifacts.sh) calls the above script. But I think we can keep the changes in the above script.
   
   I didn't even think about the `heron-spi` jar.  Ok, thanks for the feedback.  Let me do a bit of thinking on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis commented on pull request #3778: Joshfischer/3774/pom dependencies

Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3778:
URL: https://github.com/apache/incubator-heron/pull/3778#issuecomment-1052555733


   Actually, we need to update [this script](https://github.com/apache/incubator-heron/blob/master/scripts/ci/build_maven_artifacts.sh) to pull the correct artifacts. For example, I don't think it should be referencing `api-shaded.jar`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis commented on pull request #3778: Joshfischer/3774/pom dependencies

Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3778:
URL: https://github.com/apache/incubator-heron/pull/3778#issuecomment-1052559504


   Also, should these two lines be updated to reference the final Heron API dependency (and not the individual Topology/Streamlet jars that we don't publish)?
   
   https://github.com/apache/incubator-heron/blob/ebd7ceaeb7cb4aeddf21e8a51a233d53e2afca0d/examples/src/java/BUILD#L10[
   ](https://github.com/apache/incubator-heron/blob/ebd7ceaeb7cb4aeddf21e8a51a233d53e2afca0d/examples/src/java/BUILD#L29)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis commented on pull request #3778: Joshfischer/3774/pom dependencies

Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3778:
URL: https://github.com/apache/incubator-heron/pull/3778#issuecomment-1052548973


   The pom.xml templates are used to generate pom files for various artifacts. Not sure if this scripts needs to be changed. For example, are the dependencies the same for heron-api and heron-spi? https://github.com/apache/incubator-heron/blob/master/release/maven/maven-pom-version.sh
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis commented on pull request #3778: Joshfischer/3774/pom dependencies

Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3778:
URL: https://github.com/apache/incubator-heron/pull/3778#issuecomment-1052563279


   Also, this insistence on random "copy" `genrule`s is driving me crazy. Why are they there? It seemed 6 years ago it used to be a `jar_jar` shading process, but that was removed. But instead of removing the target, they changed it to a copy which renames the `unshaded` to `shaded`. 
   
   Just found this old PR using Git Blame. Happy to finally shed some light on this. But feels like we can clean this up. Doesn't have to be in this PR, but in a futture PR we should remove these random copies. https://github.com/apache/incubator-heron/blob/ebd7ceaeb7cb4aeddf21e8a51a233d53e2afca0d/examples/src/java/BUILD#L17-L22


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis edited a comment on pull request #3778: Joshfischer/3774/pom dependencies

Posted by GitBox <gi...@apache.org>.
nicknezis edited a comment on pull request #3778:
URL: https://github.com/apache/incubator-heron/pull/3778#issuecomment-1052548973


   The pom.xml templates are used to generate pom files for various artifacts. Not sure if this scripts needs to be changed. For example, are the dependencies the same for heron-api and heron-spi? https://github.com/apache/incubator-heron/blob/master/release/maven/maven-pom-version.sh
   
   Edit: [This script](https://github.com/apache/incubator-heron/blob/master/scripts/ci/build_maven_artifacts.sh) calls the above script. But I think we can keep the changes in the above script.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org