You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/05 06:50:36 UTC

[GitHub] [spark] itholic commented on a diff in pull request #37770: [SPARK-40314][SQL][PYTHON] Add scala and python bindings for inline and inline_outer

itholic commented on code in PR #37770:
URL: https://github.com/apache/spark/pull/37770#discussion_r962541002


##########
python/pyspark/sql/functions.py:
##########
@@ -5956,6 +5978,33 @@ def posexplode_outer(col: "ColumnOrName") -> Column:
     return _invoke_function_over_columns("posexplode_outer", col)
 
 
+def inline_outer(col: "ColumnOrName") -> Column:
+    """
+    Explodes an array of structs into a table.
+    Unlike inline, if the array is null or empty then null is produced for each nested column.
+
+    .. versionadded:: 3.4.0
+

Review Comment:
   And also we can add `See Also` ?
   
   e.g.
   ```python
   See Also
   ---------
   :meth:`explode_outer`
   :meth:`inline`
   ```



##########
python/pyspark/sql/functions.py:
##########
@@ -5956,6 +5978,33 @@ def posexplode_outer(col: "ColumnOrName") -> Column:
     return _invoke_function_over_columns("posexplode_outer", col)
 
 
+def inline_outer(col: "ColumnOrName") -> Column:
+    """
+    Explodes an array of structs into a table.
+    Unlike inline, if the array is null or empty then null is produced for each nested column.
+
+    .. versionadded:: 3.4.0
+

Review Comment:
   And also we can add `See Also` ?
   
   e.g.
   ```python
   See Also
   --------
   :meth:`explode_outer`
   :meth:`inline`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org