[jira] [Commented] (LOG4PHP-143) LoggerConfiguratorPhp does not accept INT constants for appender threshold

["Ivan Habunek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4PHP-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065815#comment-13065815 ] 

Ivan Habunek commented on LOG4PHP-143:
--------------------------------------

Hi Justin,

Thanks for you submission. 

Actually, the problem is not in the toLevel() method, but but in LoggerAppender::setThreshold() which does not accept integers.

I have fixed the problem. It is now possible to set the logger level using int constants (e.g. LoggerLevel::FATAL) and LoggerLevel objects (e.g. LoggerLevel::getLevelFatal()) as well as string labels (e.g. 'FATAL'). I also added some tests just to be on the safe side. :)

Best regards,
Ivan

> LoggerConfiguratorPhp does not accept INT constants for appender threshold
> --------------------------------------------------------------------------
>
>                 Key: LOG4PHP-143
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-143
>             Project: Log4php
>          Issue Type: Bug
>            Reporter: Justin Cherniak
>
> When you specify a threshold in a Php configuration file using the typical LoggerLevel::_____ constants (such as LoggerLevel::ALL), the operation fails to set the proper threshold on the appender and it always defaults to DEBUG.
> If you specify a string for the threshold, then it works properly.
> For example:
>   $config['appenders']["email"] = array(
>     'class' => 'LoggerAppenderMailEvent',
>     'to' => $email,
>     'from' => variable_get('site_mail', ini_get('sendmail_from')),
>     'subject' => "log4php event on $hostname",
>     'layout' => $layout,
>     'threshold' => LoggerLevel::FATAL
>   );  
> fails and sets the logger level to DEBUG, while this:
>   $config['appenders']["email"] = array(
>     'class' => 'LoggerAppenderMailEvent',
>     'to' => $email,
>     'from' => variable_get('site_mail', ini_get('sendmail_from')),
>     'subject' => "log4php event on $hostname",
>     'layout' => $layout,
>     'threshold' => 'FATAL'
>   );  
> works properly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira